Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 7584024: views omnibox popup: Setup the parent Widget, instead of the parent NativeView. (Closed)

Created:
9 years, 4 months ago by sadrul
Modified:
9 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

views omnibox popup: Setup the parent Widget, instead of the parent NativeView. In views-desktop world, the omnibox popup should be parented to the widget the location-bar belongs to. This fixes pointer events on the popup in touchui. BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95838

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Messages

Total messages: 4 (0 generated)
sadrul
9 years, 4 months ago (2011-08-07 04:25:25 UTC) #1
sky
http://codereview.chromium.org/7584024/diff/14/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc File chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc (right): http://codereview.chromium.org/7584024/diff/14/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc#newcode360 chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc:360: params.parent_widget = location_bar_->GetWidget(); Should InitParams parent_widget be a const* ...
9 years, 4 months ago (2011-08-08 16:35:28 UTC) #2
sadrul
http://codereview.chromium.org/7584024/diff/14/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc File chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc (right): http://codereview.chromium.org/7584024/diff/14/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc#newcode360 chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc:360: params.parent_widget = location_bar_->GetWidget(); On 2011/08/08 16:35:28, sky wrote: > ...
9 years, 4 months ago (2011-08-08 17:05:33 UTC) #3
sky
9 years, 4 months ago (2011-08-08 17:24:52 UTC) #4
Ok, LGTM

Powered by Google App Engine
This is Rietveld 408576698