chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 7584024: views omnibox popup: Setup the parent Widget, instead of the parent NativeView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 7584024: views omnibox popup: Setup the parent Widget, instead of the parent NativeView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc ('K') | « chrome/browser/ui/views/omnibox/omnibox_view_views.h ('k') | chrome/browser/ui/views/omnibox/omnibox_view_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index cdab9b30190ce812fdc320e33dec5d49bd50cd8b..4477bb08423558cb648115702e7017dc5126649b 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -140,7 +140,7 @@ OmniboxViewViews::OmniboxViewViews(AutocompleteEditController* controller,

Profile* profile,

CommandUpdater* command_updater,

bool popup_window_mode,

- const views::View* location_bar)

+ views::View* location_bar)

: model_(new AutocompleteEditModel(this, controller, profile)),

popup_view_(CreatePopupView(profile, location_bar)),

controller_(controller),

@@ -690,7 +690,7 @@ void OmniboxViewViews::SelectRange(size_t caret, size_t end) {

AutocompletePopupView* OmniboxViewViews::CreatePopupView(

Profile* profile,

- const View* location_bar) {

+ View* location_bar) {

#if defined(TOUCH_UI)

typedef TouchAutocompletePopupContentsView AutocompleteContentsView;

#else