Issue 7584018: FTP: fix directory listing parsing for Hylafax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7584018: FTP: fix directory listing parsing for Hylafax (Closed)

Created:
9 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 4 months ago

Reviewers:
eroman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

FTP: fix directory listing parsing for Hylafax BUG=90807 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96073

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -5 lines)			Patch
A	net/data/ftp/dir-listing-ls-28	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	net/data/ftp/dir-listing-ls-28.expected	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_ls.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_ls_unittest.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Paweł Hajdan Jr.

Gavin, could you take a look? It seems that Eric is OOO.

9 years, 4 months ago (2011-08-08 20:27:30 UTC) #2

eroman

I was gone fri-monday. Back now, I can resume this changelist.

9 years, 4 months ago (2011-08-09 21:14:25 UTC) #3

LGTM