FTP: fix directory listing parsing for Hylafax

net/ftp/ftp_directory_listing_parser_ls.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_directory_listing_parser_ls.h"
 
 #include <vector>
 
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
@@ skipping 15 matching lines @@
   // x - file is executable
   // s or S - setuid/setgid bit set
   // t or T - "sticky" bit set
   return ((text[0] == 'r' || text[0] == '-') &&
           (text[1] == 'w' || text[1] == '-') &&
           (text[2] == 'x' || text[2] == 's' || text[2] == 'S' ||
            text[2] == 't' || text[2] == 'T' || text[2] == '-'));
 }
 
 bool LooksLikeUnixPermissionsListing(const string16& text) {
-  if (text.length() < 10)
+  if (text.length() < 7)
     return false;
 
   // Do not check the first character (entry type). There are many weird
   // servers that use special file types (for example Plan9 and append-only
   // files). Fortunately, the rest of the permission listing is more consistent.
 
   // Do not check the rest of the string. Some servers fail to properly
   // separate this column from the next column (number of links), resulting
   // in additional characters at the end. Also, sometimes there is a "+"
   // sign at the end indicating the file has ACLs set.
+
+  // In fact, we don't even expect three "rwx" triplets of permission
+  // listing, as some FTP servers like Hylafax only send two.
   return (LooksLikeUnixPermission(text.substr(1, 3)) &&
-          LooksLikeUnixPermission(text.substr(4, 3)) &&
-          LooksLikeUnixPermission(text.substr(7, 3)));
+          LooksLikeUnixPermission(text.substr(4, 3)));
 }
 
 bool LooksLikePermissionDeniedError(const string16& text) {
   // Try to recognize a three-part colon-separated error message:
   //
   //   1. ftpd server name
   //   2. directory name (often just ".")
   //   3. message text (usually "Permission denied")
   std::vector<string16> parts;
   base::SplitString(CollapseWhitespace(text, false), ':', &parts);
@@ skipping 151 matching lines @@
         entry.name = entry.name.substr(0, pos);
     }
 
     entries->push_back(entry);
   }
 
   return true;
 }
 
 }  // namespace net