Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: media/base/media_log.h

Issue 7584013: Log PipelineImpl events to MediaLog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/media_log.cc » ('j') | media/base/media_log_event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.h
diff --git a/media/base/media_log.h b/media/base/media_log.h
index fcf0c31714540ebd7cb5f360ce7d80add4a27703..66ac22bc69e0aaaa588d778df7c303519ec18e24 100644
--- a/media/base/media_log.h
+++ b/media/base/media_log.h
@@ -8,20 +8,24 @@
#include "base/memory/ref_counted.h"
#include "media/base/media_log_event.h"
+#include "media/base/pipeline_impl.h"
namespace media {
class MediaLog : public base::RefCountedThreadSafe<MediaLog> {
public:
scherkus (not reviewing) 2011/08/08 23:14:15 nit: want to nuke this blank line?
Scott Franklin 2011/08/09 00:31:28 I thought the rule was blank line before //?
scherkus (not reviewing) 2011/08/09 00:58:07 Ah! I should clarify. Blank line before // UNLESS
- // Return a string to represent an EventType.
+ // Convert various enums to strings.
static const char* EventTypeToString(MediaLogEvent::Type type);
+ static const char* PipelineStateToString(PipelineImpl::State);
MediaLog();
// Methods called by loggers when events occur. These generate appropriate
// event parameters so the caller need not worry about them.
void Load(const std::string& url);
+ void Seek(float seconds);
+ void SetPipelineState(PipelineImpl::State state);
// Add an event to this log. Overriden by inheritors to actually do something
// with it.
« no previous file with comments | « no previous file | media/base/media_log.cc » ('j') | media/base/media_log_event.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698