Log PipelineImpl events to MediaLog.

media/base/media_log_event.h

Index: media/base/media_log_event.h
diff --git a/media/base/media_log_event.h b/media/base/media_log_event.h
index dd1735e27c920bab65e3785689cbe7c5dfb75ec6..09bae192b01c0f6ef7c30c6fe1d053a59c57d021 100644
--- a/media/base/media_log_event.h
+++ b/media/base/media_log_event.h
@@ -13,19 +13,32 @@ namespace media {
 
 struct MediaLogEvent {
   enum Type {
-    // A media player is being created or destroyed.
+    // A WebMediaPlayer is being created or destroyed.
     // params: none.
-    CREATING,
-    DESTROYING,
+    WEBMEDIAPLAYER_CREATED,
+    WEBMEDIAPLAYER_DESTROYED,
+
+    // A PipelineImpl is being created or destroyed.
+    // params: none.
+    PIPELINE_CREATED,
+    PIPELINE_DESTROYED,
 
     // A media player is loading a resource.
     // params: "url": <URL of the resource>.
     LOAD,
 
+    // A media player has started seeking.
+    // params: "seek_target": <number of seconds to which to seek>.
+    SEEK,
+
     // A media player has been told to play or pause.
     // params: none.
     PLAY,
     PAUSE,
+
+    // The state of PipelineImpl has changed.
+    // params: "pipeline_state": <intergral value of the state>.

[scherkus (not reviewing), 2011/08/08 23:14:15]

what if this was setting a string so that PipelineImpl could do the int ->
string conversion?

do we really need the pipeline states as ints?

[Scott Franklin, 2011/08/09 00:31:28]

oops, forgot to update the comment.
The event does actually take a string. It gets converted from a
PipelineImpl::State to a string in MediaLog because I didn't think PipelineImpl
should have to care about naming the states.
I could easily dump the giant switch statement into PipelineImpl::SetState() if
that would be better.

The original plan was to be similar to net-internals, which sends its page
integer values of events and a map to convert them to strings. Unfortunately,
that wasn't guaranteed to reflect changes to the State enum, while the large
switch statement throws a compiler error if you miss one.

+    PIPELINE_STATE_CHANGED,
   };
 
   int32 id;