 Chromium Code Reviews
 Chromium Code Reviews Issue 7583049:
  Record UMA statistics for file_stream operations.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 7583049:
  Record UMA statistics for file_stream operations.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: net/base/file_stream.h | 
| diff --git a/net/base/file_stream.h b/net/base/file_stream.h | 
| index da42afb944603336fd170ae90016f2cd95633b62..aca12b6f56efb00d851f680c6b0878e93a968342 100644 | 
| --- a/net/base/file_stream.h | 
| +++ b/net/base/file_stream.h | 
| @@ -14,6 +14,7 @@ | 
| #include "base/memory/scoped_ptr.h" | 
| #include "base/platform_file.h" | 
| #include "net/base/completion_callback.h" | 
| +#include "net/base/file_stream_metrics.h" | 
| 
cbentzel
2011/08/18 13:31:28
This include isn't needed.
 
ahendrickson
2011/08/18 15:56:45
Done.
 | 
| #include "net/base/net_export.h" | 
| class FilePath; | 
| @@ -132,10 +133,15 @@ class NET_EXPORT FileStream { | 
| // This method should not be called if the stream was opened READ_ONLY. | 
| int Flush(); | 
| + // Turns on UMA error statistics gathering. | 
| + void EnableErrorStatistics(); | 
| + | 
| private: | 
| class AsyncContext; | 
| friend class AsyncContext; | 
| + int RecordAndMapError(int error, FileErrorSource source); | 
| 
cbentzel
2011/08/18 13:31:28
This doesn't need to be a member function. It can
 
ahendrickson
2011/08/18 15:56:45
Done.
 | 
| + | 
| // This member is used to support asynchronous reads. It is non-null when | 
| // the FileStream was opened with PLATFORM_FILE_ASYNC. | 
| scoped_ptr<AsyncContext> async_context_; | 
| @@ -143,6 +149,7 @@ class NET_EXPORT FileStream { | 
| base::PlatformFile file_; | 
| int open_flags_; | 
| bool auto_closed_; | 
| + bool record_uma_; | 
| DISALLOW_COPY_AND_ASSIGN(FileStream); | 
| }; |