Record UMA statistics for file_stream operations.

net/base/file_stream.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines FileStream, a basic interface for reading and writing files
 // synchronously or asynchronously with support for seeking to an offset.
 // Note that even when used asynchronously, only one operation is supported at
 // a time.
 
 #ifndef NET_BASE_FILE_STREAM_H_
 #define NET_BASE_FILE_STREAM_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
 #include "base/platform_file.h"
 #include "net/base/completion_callback.h"
+#include "net/base/file_stream_metrics.h"

[cbentzel, 2011/08/18 13:31:28]

This include isn't needed.

[ahendrickson, 2011/08/18 15:56:45]

Done.

 #include "net/base/net_export.h"
 
 class FilePath;
 
 namespace net {
 
 // TODO(darin): Move this to a more generic location.
 // This explicit mapping matches both FILE_ on Windows and SEEK_ on Linux.
 enum Whence {
   FROM_BEGIN   = 0,
@@ skipping 98 matching lines @@
   // Forces out a filesystem sync on this file to make sure that the file was
   // written out to disk and is not currently sitting in the buffer. This does
   // not have to be called, it just forces one to happen at the time of
   // calling.
   //
   /// Returns an error code if the operation could not be performed.
   //
   // This method should not be called if the stream was opened READ_ONLY.
   int Flush();
 
+  // Turns on UMA error statistics gathering.
+  void EnableErrorStatistics();
+
  private:
   class AsyncContext;
   friend class AsyncContext;
 
+  int RecordAndMapError(int error, FileErrorSource source);

[cbentzel, 2011/08/18 13:31:28]

This doesn't need to be a member function. It can just be a function defined in
file_stream_posix and file_stream_win. Then you can remove the
file_stream_metrics include.

[ahendrickson, 2011/08/18 15:56:45]

Done.

+
   // This member is used to support asynchronous reads.  It is non-null when
   // the FileStream was opened with PLATFORM_FILE_ASYNC.
   scoped_ptr<AsyncContext> async_context_;
 
   base::PlatformFile file_;
   int open_flags_;
   bool auto_closed_;
+  bool record_uma_;
 
   DISALLOW_COPY_AND_ASSIGN(FileStream);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_FILE_STREAM_H_