Issue 7578015: Improve the usability of the "TLD changed" infobar by changing the strings:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7578015: Improve the usability of the "TLD changed" infobar by changing the strings: (Closed)

Created:
9 years, 4 months ago by Peter Kasting

Modified:
8 years, 9 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Improve the usability of the "TLD changed" infobar by changing the strings: OLD: It looks like you've moved. Would you like to use http://www.google.de/? [Yes] [No] NEW: Would you like to search with google.de instead of google.fr? [Switch to google.de] [Keep using google.fr] _Learn more_ BUG=85671 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95885

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -12 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/google/google_url_tracker.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/google/google_url_tracker.cc	View		4 chunks	+27 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/conflicts_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Glen, can you r+ or propose any changes on behalf of the UI leads? I ...

9 years, 4 months ago (2011-08-04 22:08:14 UTC) #1

Glen Murphy

LGTM. If the text is too long, we can drop the "Would you like to"

9 years, 4 months ago (2011-08-08 18:08:05 UTC) #2

xantilon

8 years, 9 months ago (2012-03-12 03:46:18 UTC) #3

On 2011/08/08 18:08:05, Glen Murphy wrote:
> LGTM.
> 
> If the text is too long, we can drop the "Would you like to"

PLease, please let me disable that question completely. This is very annoying,
if you use VPN. Watch comments from other frustrated users here.
http://code.google.com/p/chromium/issues/detail?id=85671

Expand Messages | Collapse Messages