Issue 7576005: Revert 95414 - Future proof against things like http://crbug.com/91521

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7576005: Revert 95414 - Future proof against things like http://crbug.com/91521 (Closed)

Created:
9 years, 4 months ago by dmac

Modified:
9 years, 4 months ago

Reviewers:
dmac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 95414 - Future proof against things like http://crbug.com/91521 BUG=91521 TEST=Remove ffmpegsumo.so from a mac chrome build and attempt to use it as a client in a chromoting session. Check your logs. You should see Media library not initialized. Also, plugin shouldn't crash. Review URL: http://codereview.chromium.org/7562016 TBR=dmaclach@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95415

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -32 lines)			Patch
M	remoting/client/client_context.h	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	remoting/client/client_context.cc	View	3 chunks	+6 lines, -14 lines	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View	3 chunks	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages