Issue 7562016: Future proof against things like http://crbug.com/91521

Issue 7562016: Future proof against things like http://crbug.com/91521 (Closed)

Created:
9 years, 4 months ago by dmac

Modified:
9 years, 4 months ago

Reviewers:
awong

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Future proof against things like http://crbug.com/91521 BUG=91521 TEST=Remove ffmpegsumo.so from a mac chrome build and attempt to use it as a client in a chromoting session. Check your logs. You should see Media library not initialized. Also, plugin shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95414 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95421

Patch Set 1 #

Patch Set 2 : get rid of xib #

Patch Set 3 : get rid of xib again? #

Patch Set 4 : better fix #

Patch Set 5 : fix up comment #

Total comments: 2

Patch Set 6 : respond to awong's issues #

Total comments: 1

Patch Set 7 : added comment about threading #

Patch Set 8 : fixed up copyright #

Patch Set 9 : fix up logging change #

Patch Set 10 : fix merge #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	remoting/client/plugin/chromoting_instance.cc	View	1 2 3 4 5 6 7 8	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

awong

http://codereview.chromium.org/7562016/diff/3002/remoting/client/client_context.h File remoting/client/client_context.h (right): http://codereview.chromium.org/7562016/diff/3002/remoting/client/client_context.h#newcode20 remoting/client/client_context.h:20: virtual ~ClientContext(); Why is ClientContext's destructor virtual if it ...

9 years, 4 months ago (2011-08-03 21:45:02 UTC) #2

dmac

On 2011/08/03 21:45:02, awong wrote: > http://codereview.chromium.org/7562016/diff/3002/remoting/client/client_context.h > File remoting/client/client_context.h (right): > > http://codereview.chromium.org/7562016/diff/3002/remoting/client/client_context.h#newcode20 > ...

9 years, 4 months ago (2011-08-03 22:08:36 UTC) #3

awong

9 years, 4 months ago (2011-08-03 22:14:22 UTC) #4

LGTM with nit

http://codereview.chromium.org/7562016/diff/6002/remoting/client/client_conte...
File remoting/client/client_context.h (right):

http://codereview.chromium.org/7562016/diff/6002/remoting/client/client_conte...
remoting/client/client_context.h:22: void Start();
Add comment hat Start and Stop must be called from the same thread?

Expand Messages | Collapse Messages