Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1723)

Unified Diff: content/renderer/render_view.h

Issue 7570001: Implement touch selection for RWHVV. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: synced and modified according to comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view.h
diff --git a/content/renderer/render_view.h b/content/renderer/render_view.h
index 0db56159c59f059d08cb67a305904d0e979d55b0..a3a572272d06213aa9e73589d63743f909cf419f 100644
--- a/content/renderer/render_view.h
+++ b/content/renderer/render_view.h
@@ -819,6 +819,7 @@ class RenderView : public RenderWidget,
int id,
bool notify_result);
void OnSelectAll();
+ void OnSelectRange(const gfx::Point& start, const gfx::Point& end);
void OnSetAccessibilityFocus(int acc_obj_id);
void OnSetActive(bool active);
void OnSetAltErrorPageURL(const GURL& gurl);
@@ -1197,6 +1198,14 @@ class RenderView : public RenderWidget,
// is fine.
ObserverList<RenderViewObserver> observers_;
+ // Set if we received a ViewMsg_SelectRange from the browser and are waiting
darin (slow to review) 2011/08/05 03:51:16 nit: this comment can be a bit more brief: // Us
varunjain 2011/08/05 15:57:30 Done.
+ // for WebKit to update the selection and call us back through
+ // didChangeSelection().
+ // This is used by didChangeSelection() to determine if the selection change
+ // has happened due to an input event or due to ViewMsg_SelectRange message
+ // from the browser.
+ bool handling_select_rect_;
darin (slow to review) 2011/08/05 03:51:16 nit: handling_select_range_
varunjain 2011/08/05 15:57:30 Done.
+
// ---------------------------------------------------------------------------
// ADDING NEW DATA? Please see if it fits appropriately in one of the above
// sections rather than throwing it randomly at the end. If you're adding a

Powered by Google App Engine
This is Rietveld 408576698