Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: content/renderer/render_view.h

Issue 7570001: Implement touch selection for RWHVV. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: synced and modified according to comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <map> 10 #include <map>
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 void OnRedo(); 812 void OnRedo();
813 void OnReloadFrame(); 813 void OnReloadFrame();
814 void OnReplace(const string16& text); 814 void OnReplace(const string16& text);
815 void OnReservePageIDRange(int size_of_range); 815 void OnReservePageIDRange(int size_of_range);
816 void OnResetPageEncodingToDefault(); 816 void OnResetPageEncodingToDefault();
817 void OnScriptEvalRequest(const string16& frame_xpath, 817 void OnScriptEvalRequest(const string16& frame_xpath,
818 const string16& jscript, 818 const string16& jscript,
819 int id, 819 int id,
820 bool notify_result); 820 bool notify_result);
821 void OnSelectAll(); 821 void OnSelectAll();
822 void OnSelectRange(const gfx::Point& start, const gfx::Point& end);
822 void OnSetAccessibilityFocus(int acc_obj_id); 823 void OnSetAccessibilityFocus(int acc_obj_id);
823 void OnSetActive(bool active); 824 void OnSetActive(bool active);
824 void OnSetAltErrorPageURL(const GURL& gurl); 825 void OnSetAltErrorPageURL(const GURL& gurl);
825 void OnSetBackground(const SkBitmap& background); 826 void OnSetBackground(const SkBitmap& background);
826 void OnSetWebUIProperty(const std::string& name, const std::string& value); 827 void OnSetWebUIProperty(const std::string& name, const std::string& value);
827 void OnSetEditCommandsForNextKeyEvent(const EditCommands& edit_commands); 828 void OnSetEditCommandsForNextKeyEvent(const EditCommands& edit_commands);
828 void OnSetInitialFocus(bool reverse); 829 void OnSetInitialFocus(bool reverse);
829 #if defined(OS_MACOSX) 830 #if defined(OS_MACOSX)
830 void OnSetInLiveResize(bool in_live_resize); 831 void OnSetInLiveResize(bool in_live_resize);
831 #endif 832 #endif
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
1190 // The node that the context menu was pressed over. 1191 // The node that the context menu was pressed over.
1191 WebKit::WebNode context_menu_node_; 1192 WebKit::WebNode context_menu_node_;
1192 1193
1193 // Reports load progress to the browser. 1194 // Reports load progress to the browser.
1194 scoped_ptr<LoadProgressTracker> load_progress_tracker_; 1195 scoped_ptr<LoadProgressTracker> load_progress_tracker_;
1195 1196
1196 // All the registered observers. We expect this list to be small, so vector 1197 // All the registered observers. We expect this list to be small, so vector
1197 // is fine. 1198 // is fine.
1198 ObserverList<RenderViewObserver> observers_; 1199 ObserverList<RenderViewObserver> observers_;
1199 1200
1201 // Set if we received a ViewMsg_SelectRange from the browser and are waiting
darin (slow to review) 2011/08/05 03:51:16 nit: this comment can be a bit more brief: // Us
varunjain 2011/08/05 15:57:30 Done.
1202 // for WebKit to update the selection and call us back through
1203 // didChangeSelection().
1204 // This is used by didChangeSelection() to determine if the selection change
1205 // has happened due to an input event or due to ViewMsg_SelectRange message
1206 // from the browser.
1207 bool handling_select_rect_;
darin (slow to review) 2011/08/05 03:51:16 nit: handling_select_range_
varunjain 2011/08/05 15:57:30 Done.
1208
1200 // --------------------------------------------------------------------------- 1209 // ---------------------------------------------------------------------------
1201 // ADDING NEW DATA? Please see if it fits appropriately in one of the above 1210 // ADDING NEW DATA? Please see if it fits appropriately in one of the above
1202 // sections rather than throwing it randomly at the end. If you're adding a 1211 // sections rather than throwing it randomly at the end. If you're adding a
1203 // bunch of stuff, you should probably create a helper class and put your 1212 // bunch of stuff, you should probably create a helper class and put your
1204 // data and methods on that to avoid bloating RenderView more. You can use 1213 // data and methods on that to avoid bloating RenderView more. You can use
1205 // the Observer interface to filter IPC messages and receive frame change 1214 // the Observer interface to filter IPC messages and receive frame change
1206 // notifications. 1215 // notifications.
1207 // --------------------------------------------------------------------------- 1216 // ---------------------------------------------------------------------------
1208 1217
1209 DISALLOW_COPY_AND_ASSIGN(RenderView); 1218 DISALLOW_COPY_AND_ASSIGN(RenderView);
1210 }; 1219 };
1211 1220
1212 #endif // CONTENT_RENDERER_RENDER_VIEW_H_ 1221 #endif // CONTENT_RENDERER_RENDER_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698