Issue 7565002: Fix memory errors in ComponentUpdater::ComponentUpdater().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7565002: Fix memory errors in ComponentUpdater::ComponentUpdater(). (Closed)

Created:
9 years, 4 months ago by Hironori Bono

Modified:
9 years, 4 months ago

Reviewers:
cpu_(ooo_6.6-7.5), commit-bot: I haz the power

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix memory errors in ComponentUpdater::ComponentUpdater(). This change just fixes two trivial memory errors occurred in ComponentUpdater::ComponentUpdater(). BUG=91486 TEST=make memory bots greener. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95393

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -28 lines)			Patch
M	chrome/browser/component_updater/component_unpacker.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_service_unittest.cc	View	1	3 chunks	+2 lines, -1 line	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

On 2011/08/03 22:13:04, cpu wrote: > thanks so much. lgtm

9 years, 4 months ago (2011-08-03 22:13:11 UTC) #3

commit-bot: I haz the power

Can't apply patch for file chrome/browser/component_updater/component_updater_service_unittest.cc. While running patch -p0 --forward --force; patching file chrome/browser/component_updater/component_updater_service_unittest.cc ...

9 years, 4 months ago (2011-08-03 22:46:32 UTC) #4

never mind I see you commited :)

Expand Messages | Collapse Messages