chrome/browser/component_updater/component_updater_service_unittest.cc - Issue 7565002: Fix memory errors in ComponentUpdater::ComponentUpdater().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_updater_service_unittest.cc

Issue 7565002: Fix memory errors in ComponentUpdater::ComponentUpdater(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/component_updater/component_updater_service_unittest.cc

===================================================================

--- chrome/browser/component_updater/component_updater_service_unittest.cc (revision 95372)

+++ chrome/browser/component_updater/component_updater_service_unittest.cc (working copy)

@@ -8,6 +8,7 @@

#include "base/file_path.h"

#include "base/file_util.h"

#include "base/path_service.h"

+#include "base/values.h"

#include "chrome/browser/component_updater/component_updater_interceptor.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_notification_types.h"

@@ -74,6 +75,7 @@

virtual bool Install(base::DictionaryValue* manifest,

const FilePath& unpack_path) OVERRIDE {

++install_count_;

+ delete manifest;

return file_util::Delete(unpack_path, true);

}

@@ -292,4 +294,3 @@

delete com2.installer;

xmlCleanupGlobals();

}