Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5219)

Unified Diff: chrome/browser/sync/js_sync_manager_observer_unittest.cc

Issue 7564023: [Sync] Fix memory leak in JsSyncManagerObserver unit tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/heapcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/js_sync_manager_observer_unittest.cc
diff --git a/chrome/browser/sync/js_sync_manager_observer_unittest.cc b/chrome/browser/sync/js_sync_manager_observer_unittest.cc
index 74a2a075783af0243b2540bd7647be0698775bee..2057dc7ca336ca4130219099e46f0cdf2dc244da 100644
--- a/chrome/browser/sync/js_sync_manager_observer_unittest.cc
+++ b/chrome/browser/sync/js_sync_manager_observer_unittest.cc
@@ -33,15 +33,18 @@ class JsSyncManagerObserverTest : public testing::Test {
mock_js_event_handler_.AsWeakHandle());
}
+ private:
+ // This must be destroyed after the member variables below in order
+ // for WeakHandles to be destroyed properly.
+ MessageLoop message_loop_;
+
+ protected:
StrictMock<MockJsEventHandler> mock_js_event_handler_;
JsSyncManagerObserver js_sync_manager_observer_;
void PumpLoop() {
message_loop_.RunAllPending();
}
-
- private:
- MessageLoop message_loop_;
};
TEST_F(JsSyncManagerObserverTest, NoArgNotifiations) {
« no previous file with comments | « no previous file | tools/heapcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698