[Sync] Fix memory leak in JsSyncManagerObserver unit tests

chrome/browser/sync/js_sync_manager_observer_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/js_sync_manager_observer.h"
 
 #include <cstddef>
 
 #include "base/basictypes.h"
 #include "base/message_loop.h"
@@ skipping 15 matching lines @@
 using ::testing::InSequence;
 using ::testing::StrictMock;
 
 class JsSyncManagerObserverTest : public testing::Test {
  protected:
   JsSyncManagerObserverTest() {
     js_sync_manager_observer_.SetJsEventHandler(
         mock_js_event_handler_.AsWeakHandle());
   }
 
+ private:
+  // This must be destroyed after the member variables below in order
+  // for WeakHandles to be destroyed properly.
+  MessageLoop message_loop_;
+
+ protected:
   StrictMock<MockJsEventHandler> mock_js_event_handler_;
   JsSyncManagerObserver js_sync_manager_observer_;
 
   void PumpLoop() {
     message_loop_.RunAllPending();
   }
-
- private:
-  MessageLoop message_loop_;
 };
 
 TEST_F(JsSyncManagerObserverTest, NoArgNotifiations) {
   InSequence dummy;
 
   EXPECT_CALL(mock_js_event_handler_,
               HandleJsEvent("onInitializationComplete",
                             HasDetails(JsEventDetails())));
   EXPECT_CALL(mock_js_event_handler_,
               HandleJsEvent("onStopSyncingPermanently",
@@ skipping 267 matching lines @@
                                                &trans, &changes[i],
                                                syncable::MODEL_TYPE_COUNT - i);
   }
 
   test_user_share.TearDown();
   PumpLoop();
 }
 
 }  // namespace
 }  // namespace browser_sync