Issue 7563001: [mac] Disable system window animation when creating a window as part of tab dragging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7563001: [mac] Disable system window animation when creating a window as part of tab dragging. (Closed)

Created:
9 years, 4 months ago by csilv

Modified:
9 years, 4 months ago

Reviewers:
Mark Mentovai, Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[mac] Disable system window animation when creating a window as part of tab dragging. BUG=91206 TEST=Detatch tab from a window, Lion swoosh animation should not take place. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95431

Patch Set 1 #

Patch Set 2 : eliminate release compile warning #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	M	chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm	View	1	3 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

9 years, 4 months ago (2011-08-04 03:52:46 UTC) #4

I didn’t realize you wanted both of us to review. I saw this last night like 3
minutes after Avi did but didn’t comment on it because he already gave you the
LG.

I thought it was LG too.

So:

LGTM.

Expand Messages | Collapse Messages