[mac] Disable system window animation when creating a window as part of tab dragging.

chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h"
 
 #import "base/mac/mac_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_controller.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_controller_target.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_view.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"
 
+// Provide the forward-declarations of new 10.7 SDK symbols so they can be
+// called when building with the 10.5 SDK.
+#if !defined(MAC_OS_X_VERSION_10_7) || \
+MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7
+
+enum {
+  NSWindowAnimationBehaviorDefault = 0,
+  NSWindowAnimationBehaviorNone = 2,
+  NSWindowAnimationBehaviorDocumentWindow = 3,
+  NSWindowAnimationBehaviorUtilityWindow = 4,
+  NSWindowAnimationBehaviorAlertPanel = 5
+};
+typedef NSInteger NSWindowAnimationBehavior;
+
+@interface NSWindow (LionSDKDeclarations)
+- (NSWindowAnimationBehavior)animationBehavior;
+- (void)setAnimationBehavior:(NSWindowAnimationBehavior)newAnimationBehavior;
+@end
+
+#endif  // MAC_OS_X_VERSION_10_7
+
 const CGFloat kTearDistance = 36.0;
 const NSTimeInterval kTearDuration = 0.333;
 
 @interface TabStripDragController (Private)
 - (void)resetDragControllers;
 - (NSArray*)dropTargetsForController:(TabWindowController*)dragController;
 - (void)setWindowBackgroundVisibility:(BOOL)shouldBeVisible;
 // TODO(davidben): When we stop supporting 10.5, this can be removed.
 - (int)getWorkspaceID:(NSWindow*)window useCache:(BOOL)useCache;
 @end
@@ skipping 211 matching lines @@
     // controller.
     draggedController_ =
         [sourceController_ detachTabToNewWindow:[draggedTab_ tabView]];
     dragWindow_ = [draggedController_ window];
     [dragWindow_ setAlphaValue:0.0];
     if (![sourceController_ hasLiveTabs]) {
       sourceController_ = draggedController_;
       sourceWindow_ = dragWindow_;
     }
 
+    // Disable window animation before calling |orderFront:| when detatching
+    // to a new window.
+    NSWindowAnimationBehavior savedAnimationBehavior = 0;
+    if ([dragWindow_ respondsToSelector:@selector(animationBehavior)] &&
+        [dragWindow_ respondsToSelector:@selector(setAnimationBehavior:)]) {
+      savedAnimationBehavior = [dragWindow_ animationBehavior];
+      [dragWindow_ setAnimationBehavior:NSWindowAnimationBehaviorNone];
+    }
+
     // If dragging the tab only moves the current window, do not show overlay
     // so that sheets stay on top of the window.
     // Bring the target window to the front and make sure it has a border.
     [dragWindow_ setLevel:NSFloatingWindowLevel];
     [dragWindow_ setHasShadow:YES];
     [dragWindow_ orderFront:nil];
     [dragWindow_ makeMainWindow];
     [draggedController_ showOverlay];
     dragOverlay_ = [draggedController_ overlayWindow];
     // Force the new tab button to be hidden. We'll reset it on mouse up.
     [draggedController_ showNewTabButton:NO];
     tearTime_ = [NSDate timeIntervalSinceReferenceDate];
     tearOrigin_ = sourceWindowFrame_.origin;
+
+    // Restore window animation behavior
+    if ([dragWindow_ respondsToSelector:@selector(animationBehavior)] &&
+        [dragWindow_ respondsToSelector:@selector(setAnimationBehavior:)]) {
+      [dragWindow_ setAnimationBehavior:savedAnimationBehavior];
+    }
   }
 
   // TODO(pinkerton): http://crbug.com/25682 demonstrates a way to get here by
   // some weird circumstance that doesn't first go through mouseDown:. We
   // really shouldn't go any farther.
   if (!draggedController_ || !sourceController_)
     return;
 
   // When the user first tears off the window, we want slide the window to
   // the current mouse location (to reduce the jarring appearance). We do this
@@ skipping 246 matching lines @@
       NOTREACHED();
     }
   }
   if (useCache) {
     workspaceIDCache_[windowID] = workspace;
   }
   return workspace;
 }
 
 @end