Sessions sync integration tests: check all windows and tabs when searching for a URL.

Sessions sync integration tests: check all windows and tabs when searching for a URL.

This patch modifies LiveSessionsSyncTest::ModelAssociatorHasTabWithUrl so that it is no longer hard-coded to check only windows[0]->tabs[0].  With this change, it iterates through all windows and all tabs, so it will return true if any tab in the given profile has the specified URL.

This change has no immediate effect, but it is intended to be one step towards eventually adding tab/session sync performance tests.

I also added LiveSessionsSyncTest::GetLocalSession to eliminate a little bit of repeated code.

BUG=
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95357

[Nicolas Zea, 2011-08-04 00:28:49]

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
File chrome/test/live_sync/live_sessions_sync_test.cc (right):

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
chrome/test/live_sync/live_sessions_sync_test.cc:43: if
(!GetProfile(index)->GetProfileSyncService()->
return GetProfile(index)->...

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
chrome/test/live_sync/live_sessions_sync_test.cc:70: return false;
change to continue;

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
chrome/test/live_sync/live_sessions_sync_test.cc:75: VLOG(1) << "Empty
navigations vector";
continue;

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
chrome/test/live_sync/live_sessions_sync_test.cc:83: return false;
change to continue;

[braffert, 2011-08-04 00:38:36]

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
File chrome/test/live_sync/live_sessions_sync_test.cc (right):

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
chrome/test/live_sync/live_sessions_sync_test.cc:43: if
(!GetProfile(index)->GetProfileSyncService()->
On 2011/08/04 00:28:49, nzea wrote:
> return GetProfile(index)->...

Done.

http://codereview.chromium.org/7562020/diff/1/chrome/test/live_sync/live_sess...
chrome/test/live_sync/live_sessions_sync_test.cc:83: return false;
On 2011/08/04 00:28:49, nzea wrote:
> change to continue;

Done for all 3.  I was trying to replicate the original function, which would
immediately return false if an empty vector was seen, but now I see why continue
is more appropriate here.

[Nicolas Zea, 2011-08-04 00:43:16]

LGTM.