Sessions sync integration tests: check all windows and tabs when searching for a URL.

chrome/test/live_sync/live_sessions_sync_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/live_sync/live_sessions_sync_test.h"
 
 #include "base/test/test_timeouts.h"
 #include "base/time.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
@@ skipping 20 matching lines @@
   }
 
   // Go through and make the Browsers.
   for (int i = 0; i < num_clients(); ++i) {
     browsers_.push_back(Browser::Create(GetProfile(i)));
   }
 
   return true;
 }
 
+bool LiveSessionsSyncTest::GetLocalSession(int index,
+                                           const SyncedSession** session) {
+  if (!GetProfile(index)->GetProfileSyncService()->

[Nicolas Zea, 2011/08/04 00:28:49]

return GetProfile(index)->...

[braffert, 2011/08/04 00:38:36]

Done.

+          GetSessionModelAssociator()->GetLocalSession(session)) {
+    return false;
+  }
+  return true;
+}
+
 bool LiveSessionsSyncTest::ModelAssociatorHasTabWithUrl(int index,
                                                         const GURL& url) {
   ui_test_utils::RunAllPendingInMessageLoop();
   const SyncedSession* local_session;
-  if (!GetProfile(index)->GetProfileSyncService()->
-          GetSessionModelAssociator()->GetLocalSession(&local_session)) {
-    return false;
-  }
-  if (local_session->windows.size() == 0 ||
-      local_session->windows[0]->tabs.size() == 0 ||
-      local_session->windows[0]->tabs[0]->navigations.size() == 0) {
-    VLOG(1) << "Bad vectors!";
+  if (!GetLocalSession(index, &local_session)) {
     return false;
   }
 
-  int nav_index =
-      local_session->windows[0]->tabs[0]->current_navigation_index;
-  TabNavigation nav =
-      local_session->windows[0]->tabs[0]->navigations[nav_index];
-  if (nav.virtual_url() != url) {
-    VLOG(1) << "Bad url!";
+  if (local_session->windows.size() == 0) {
+    VLOG(1) << "Empty windows vector";
     return false;
   }
-  if (nav.title().empty()) {
-    VLOG(1) << "No title!";
-    return false;
+
+  int nav_index;
+  TabNavigation nav;
+  for (std::vector<SessionWindow*>::const_iterator it =
+           local_session->windows.begin(); it != local_session->windows.end();
+           ++it) {
+    if ((*it)->tabs.size() == 0) {
+      VLOG(1) << "Empty tabs vector";
+      return false;

[Nicolas Zea, 2011/08/04 00:28:49]

change to continue;

+    }
+    for (std::vector<SessionTab*>::const_iterator tab_it =
+             (*it)->tabs.begin(); tab_it != (*it)->tabs.end(); ++tab_it) {
+      if ((*tab_it)->navigations.size() == 0) {
+        VLOG(1) << "Empty navigations vector";

[Nicolas Zea, 2011/08/04 00:28:49]

continue;

+      }
+      nav_index = (*tab_it)->current_navigation_index;
+      nav = (*tab_it)->navigations[nav_index];
+      if (nav.virtual_url() == url) {
+        VLOG(1) << "Found tab with url " << url.spec();
+        if (nav.title().empty()) {
+          VLOG(1) << "No title!";
+          return false;

[Nicolas Zea, 2011/08/04 00:28:49]

change to continue;

[braffert, 2011/08/04 00:38:36]

Done for all 3.  I was trying to replicate the original function, which would
immediately return false if an empty vector was seen, but now I see why continue
is more appropriate here.

+        }
+        return true;
+      }
+    }
   }
-  VLOG(1) << "Found tab with url " << url.spec();
-  return true;
+  VLOG(1) << "Could not find tab with url " << url.spec();
+  return false;
 }
 
 bool LiveSessionsSyncTest::OpenTab(int index, const GURL& url) {
   static const int timeout_milli = TestTimeouts::action_max_timeout_ms();
   VLOG(1) << "Opening tab: " << url.spec();
   GetBrowser(index)->ShowSingletonTab(url);
   VLOG(1) << "Waiting for session to propagate to associator.";
   base::TimeTicks start_time = base::TimeTicks::Now();
   base::TimeTicks end_time = start_time +
                              base::TimeDelta::FromMilliseconds(timeout_milli);
@@ skipping 10 matching lines @@
 
   LOG(ERROR) << "Failed to find tab after " << timeout_milli/1000.0
              << " seconds.";
   return false;
 }
 
 std::vector<SessionWindow*>* LiveSessionsSyncTest::GetLocalWindows(int index) {
   // The local session provided by GetLocalSession is owned, and has lifetime
   // controlled, by the model associator, so we must make our own copy.
   const SyncedSession* local_session;
-  if (!GetProfile(index)->GetProfileSyncService()->GetSessionModelAssociator()->
-          GetLocalSession(&local_session)) {
+  if (!GetLocalSession(index, &local_session)) {
     return NULL;
   }
   scoped_ptr<SyncedSession> session_copy(new SyncedSession());
   for (size_t w = 0; w < local_session->windows.size(); ++w) {
     const SessionWindow& window = *local_session->windows.at(w);
     scoped_ptr<SessionWindow> new_window(new SessionWindow());
     for (size_t t = 0; t < window.tabs.size(); ++t) {
       const SessionTab& tab = *window.tabs.at(t);
       scoped_ptr<SessionTab> new_tab(new SessionTab());
       new_tab->navigations.resize(tab.navigations.size());
@@ skipping 23 matching lines @@
 bool LiveSessionsSyncTest::CheckInitialState(int index) {
   if (0 != GetNumWindows(index))
     return false;
   if (0 != GetNumForeignSessions(index))
     return false;
   return true;
 }
 
 int LiveSessionsSyncTest::GetNumWindows(int index) {
   const SyncedSession* local_session;
-  if (!GetProfile(index)->GetProfileSyncService()->GetSessionModelAssociator()->
-          GetLocalSession(&local_session)) {
+  if (!GetLocalSession(index, &local_session)) {
     return 0;
   }
   return local_session->windows.size();
 }
 
 int LiveSessionsSyncTest::GetNumForeignSessions(int index) {
   std::vector<const SyncedSession*> sessions;
   if (!GetProfile(index)->GetProfileSyncService()->
           GetSessionModelAssociator()->GetAllForeignSessions(&sessions))
     return 0;
@@ skipping 130 matching lines @@
   // sync profile.
   BrowserList::CloseAllBrowsers();
   ui_test_utils::RunAllPendingInMessageLoop();
 
   // All browsers should be closed at this point, else when the framework
   // calls QuitBrowsers() we could see memory corruption.
   ASSERT_EQ(0U, BrowserList::size());
 
   LiveSyncTest::CleanUpOnMainThread();
 }