Move preferences registering to backend.

Move preferences registering to backend.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95597

[qsr (NOT THE RIGHT qsr), 2011-08-03 09:52:37]

browser/ui: sky
browser/sync: timsteele
browser/prefs: mnissler

rogerta: Globally, as you did the original change.

[qsr (NOT THE RIGHT qsr), 2011-08-03 10:10:15]

mnissler wasn't in the reviewers.

[Mattias Nissler (ping if slow), 2011-08-03 11:46:33]

prefs LGTM

[qsr (NOT THE RIGHT qsr), 2011-08-03 12:04:35]

Right mail address for rogerta

[Roger Tawa OOO till Jul 10th, 2011-08-03 12:23:48]

I'm curious why this is better than before.  With your change, the bits and
pieces related to auto-login are now spread out across two source files, whereas
before all of it was consolidated in autologin_infobar_delegate.cc|h.  Is there
a problem with including headers from chrome\browser\ui in browser_prefs.cc?

http://codereview.chromium.org/7562006/diff/1/chrome/browser/prefs/browser_pr...
File chrome/browser/prefs/browser_prefs.cc (right):

http://codereview.chromium.org/7562006/diff/1/chrome/browser/prefs/browser_pr...
chrome/browser/prefs/browser_prefs.cc:55: #include
"chrome/browser/ui/autologin_infobar_delegate.h"
should remove this #include

[TVL, 2011-08-03 12:44:42]

On 2011/08/03 12:23:48, Roger Tawa wrote:
> I'm curious why this is better than before.  With your change, the bits and
> pieces related to auto-login are now spread out across two source files,
whereas
> before all of it was consolidated in autologin_infobar_delegate.cc|h.  Is
there
> a problem with including headers from chrome\browser\ui in browser_prefs.cc?
> 
>
http://codereview.chromium.org/7562006/diff/1/chrome/browser/prefs/browser_pr...
> File chrome/browser/prefs/browser_prefs.cc (right):
> 
>
http://codereview.chromium.org/7562006/diff/1/chrome/browser/prefs/browser_pr...
> chrome/browser/prefs/browser_prefs.cc:55: #include
> "chrome/browser/ui/autologin_infobar_delegate.h"
> should remove this #include

Before SigninManager ended up depending on ui/autologin_infobar_delegate which
seems backwards.  The dependency is because the delegate was the one that
created/owned the preference and signinmanager is acting based on it.

[Roger Tawa OOO till Jul 10th, 2011-08-03 13:38:59]

lgtm (with removal of header file)

Thanks Benjamin.

[sky, 2011-08-03 14:42:26]

LGTM

[tim (not reviewing), 2011-08-04 16:53:00]

LGTM

[commit-bot: I haz the power, 2011-08-05 09:35:16]

Change committed as 95597