chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc - Issue 7558024: Add UMA metrics for blocked plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

Issue 7558024: Add UMA metrics for blocked plugins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc ('k') | chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

index 99ee7db2323c4f318d536e89f1df7a4e16cba224..0e6d56488e5a323795f314756b894f9669f0b4e4 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

@@ -49,7 +49,7 @@ TEST_F(ContentSettingBubbleModelTest, ImageRadios) {

TabSpecificContentSettings* content_settings =

contents_wrapper()->content_settings();

content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_IMAGES,

- std::string());

+ std::string(), CONTENT_SETTING_BLOCK);

scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(

ContentSettingBubbleModel::CreateContentSettingBubbleModel(

@@ -68,7 +68,7 @@ TEST_F(ContentSettingBubbleModelTest, Cookies) {

TabSpecificContentSettings* content_settings =

contents_wrapper()->content_settings();

content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES,

- std::string());

+ std::string(), CONTENT_SETTING_BLOCK);

scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(

ContentSettingBubbleModel::CreateContentSettingBubbleModel(

@@ -87,7 +87,7 @@ TEST_F(ContentSettingBubbleModelTest, Plugins) {

TabSpecificContentSettings* content_settings =

contents_wrapper()->content_settings();

content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS,

- std::string());

+ std::string(), CONTENT_SETTING_BLOCK);

scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(

ContentSettingBubbleModel::CreateContentSettingBubbleModel(

@@ -130,9 +130,9 @@ TEST_F(ContentSettingBubbleModelTest, MultiplePlugins) {

TabSpecificContentSettings* content_settings =

contents_wrapper()->content_settings();

content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS,

- fooPlugin);

+ fooPlugin, CONTENT_SETTING_BLOCK);

content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS,

- barPlugin);

+ barPlugin, CONTENT_SETTING_BLOCK);

scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(

ContentSettingBubbleModel::CreateContentSettingBubbleModel(