chrome/renderer/chrome_content_renderer_client.cc - Issue 7558024: Add UMA metrics for blocked plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 7558024: Add UMA metrics for blocked plugins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 759388adf7a80b9607e5a0df5390d40610a7b2bb..7a98085a70e9a6e3ab0f82b2c0ef1be7a530a3ca 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -459,7 +459,8 @@ WebPlugin* ChromeContentRendererClient::CreatePluginImpl(

frame, params, info.path, actual_mime_type);

}

- observer->DidBlockContentType(CONTENT_SETTINGS_TYPE_PLUGINS, resource);

+ observer->DidBlockContentType(CONTENT_SETTINGS_TYPE_PLUGINS,

+ resource, plugin_setting);

jochen (gone - plz use gerrit) 2011/08/10 15:12:03 why not record the UMA here?

Bernhard Bauer 2011/08/10 15:16:45 UserMetrics is in content/browser/ :-/

if (plugin_setting == CONTENT_SETTING_ASK) {

return CreatePluginPlaceholder(

render_view, frame, params, *group, IDR_CLICK_TO_PLAY_PLUGIN_HTML,

« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/content_settings_observer.h » ('j') | no next file with comments »