Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7555005: Moving the contents of chrome://gpu Profiling to chrome://tracing. (Closed)

Created:
9 years, 4 months ago by dominich
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews), Zhenyao Mo
Visibility:
Public.

Description

Moving the contents of chrome://gpu Profiling to chrome://tracing. BUG=91406 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95998

Patch Set 1 #

Patch Set 2 : Replace 'gpu' with 'tracing' throughout .js and .css #

Patch Set 3 : Remove tabs #

Total comments: 18

Patch Set 4 : Removing dead code #

Patch Set 5 : rebase #

Total comments: 24

Patch Set 6 : Review responses #

Total comments: 6

Patch Set 7 : Nit fixes #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -3695 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/gpu_internals.html View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/gpu_internals.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/gpu_internals/browser_bridge.js View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -4 lines 0 comments Download
D chrome/browser/resources/gpu_internals/fast_rect_renderer.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -120 lines 0 comments Download
M chrome/browser/resources/gpu_internals/info_view.js View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/gpu_internals/overlay.css View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/resources/gpu_internals/overlay.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -177 lines 0 comments Download
D chrome/browser/resources/gpu_internals/overlay_test.html View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/resources/gpu_internals/profiling_view.css View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/resources/gpu_internals/profiling_view.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/browser/resources/gpu_internals/sorted_array_utils.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/browser/resources/gpu_internals/tests/big_trace.json View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/gpu_internals/timeline.css View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/resources/gpu_internals/timeline.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -587 lines 0 comments Download
D chrome/browser/resources/gpu_internals/timeline_model.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -419 lines 0 comments Download
D chrome/browser/resources/gpu_internals/timeline_track.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -466 lines 0 comments Download
D chrome/browser/resources/gpu_internals/timeline_view.css View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/resources/gpu_internals/timeline_view.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/browser/resources/gpu_internals/tracing_controller.css View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/resources/gpu_internals/tracing_controller.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/resources/gpu_internals/tracing_controller_tests.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -227 lines 0 comments Download
A + chrome/browser/resources/tracing.html View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -18 lines 0 comments Download
A chrome/browser/resources/tracing.js View 1 2 3 4 5 6 7 8 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/resources/tracing/OWNERS View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/resources/tracing/fast_rect_renderer.js View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/tracing/overlay.css View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/tracing/overlay.js View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/tracing/overlay_test.html View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/tracing/profiling_view.css View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/tracing/profiling_view.js View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/resources/tracing/sorted_array_utils.js View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/tracing/tests/big_trace.json View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/tracing/tests/huge_trace.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/tracing/timeline.css View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/tracing/timeline.js View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/tracing/timeline_model.js View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/tracing/timeline_track.js View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/resources/tracing/timeline_view.css View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/tracing/timeline_view.js View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/resources/tracing/tracing_controller.css View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/resources/tracing/tracing_controller.js View 1 2 3 4 5 6 7 8 5 chunks +7 lines, -7 lines 0 comments Download
A chrome/browser/resources/tracing/tracing_controller_tests.js View 1 2 3 4 5 6 7 8 1 chunk +227 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 1 2 3 4 5 6 7 8 11 chunks +7 lines, -372 lines 0 comments Download
A chrome/browser/ui/webui/tracing_ui.h View 1 2 3 4 5 6 7 8 1 chunk +20 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/tracing_ui.cc View 1 2 3 4 5 6 7 8 15 chunks +175 lines, -259 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager.cc View 1 2 3 4 5 6 7 8 2 chunks +84 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
dominich
There's still bits to clean up, such as the references to 'gpu' and 'gpu_internals' in ...
9 years, 4 months ago (2011-08-03 17:56:10 UTC) #1
dominich
There's still bits to clean up, such as the references to 'gpu' and 'gpu_internals' in ...
9 years, 4 months ago (2011-08-03 18:01:03 UTC) #2
dominich
JavaScript has been updated to define everything in 'tracing' instead of 'gpu'.
9 years, 4 months ago (2011-08-03 18:32:05 UTC) #3
nduca
A few high level bits of feedback below. Some dead code in the new cc ...
9 years, 4 months ago (2011-08-04 00:50:48 UTC) #4
dominich
http://codereview.chromium.org/7555005/diff/7026/chrome/browser/resources/gpu_internals.html File chrome/browser/resources/gpu_internals.html (left): http://codereview.chromium.org/7555005/diff/7026/chrome/browser/resources/gpu_internals.html#oldcode68 chrome/browser/resources/gpu_internals.html:68: <include src="gpu_internals/info_view.html"> On 2011/08/04 00:50:48, nduca wrote: > I'd ...
9 years, 4 months ago (2011-08-04 16:55:28 UTC) #5
dominich
arv: Please look at the chrome/browser/ui/webui and chrome/browser/resources changes. jhawkins: Please look at the chrome/browser/resources ...
9 years, 4 months ago (2011-08-04 17:11:04 UTC) #6
James Hawkins
http://codereview.chromium.org/7555005/diff/17045/chrome/browser/resources/tracing.html File chrome/browser/resources/tracing.html (right): http://codereview.chromium.org/7555005/diff/17045/chrome/browser/resources/tracing.html#newcode60 chrome/browser/resources/tracing.html:60: <h1>Tracing</h1> Localize this string. http://codereview.chromium.org/7555005/diff/17045/chrome/browser/resources/tracing.js File chrome/browser/resources/tracing.js (right): http://codereview.chromium.org/7555005/diff/17045/chrome/browser/resources/tracing.js#newcode5 ...
9 years, 4 months ago (2011-08-04 17:26:35 UTC) #7
nduca
Regarding the browserBridge stuff, I think we have a bit of an architectural problem, and ...
9 years, 4 months ago (2011-08-04 18:28:46 UTC) #8
dominich
http://codereview.chromium.org/7555005/diff/17045/chrome/browser/resources/tracing.html File chrome/browser/resources/tracing.html (right): http://codereview.chromium.org/7555005/diff/17045/chrome/browser/resources/tracing.html#newcode60 chrome/browser/resources/tracing.html:60: <h1>Tracing</h1> On 2011/08/04 17:26:35, James Hawkins wrote: > Localize ...
9 years, 4 months ago (2011-08-04 22:56:12 UTC) #9
James Hawkins
LGTM with style nits. http://codereview.chromium.org/7555005/diff/17067/chrome/browser/resources/tracing.html File chrome/browser/resources/tracing.html (right): http://codereview.chromium.org/7555005/diff/17067/chrome/browser/resources/tracing.html#newcode60 chrome/browser/resources/tracing.html:60: <h1 i18n-content="tracingTitle">TITLE</h1> Localize this string ...
9 years, 4 months ago (2011-08-05 18:03:01 UTC) #10
nduca
LGTM
9 years, 4 months ago (2011-08-08 17:31:40 UTC) #11
dominich
kbr: Please take a look at the gpu_data_manager.* changes. http://codereview.chromium.org/7555005/diff/17067/chrome/browser/resources/tracing.html File chrome/browser/resources/tracing.html (right): http://codereview.chromium.org/7555005/diff/17067/chrome/browser/resources/tracing.html#newcode60 chrome/browser/resources/tracing.html:60: ...
9 years, 4 months ago (2011-08-08 17:36:12 UTC) #12
Ken Russell (switch to Gerrit)
gpu_data_manager changes LGTM
9 years, 4 months ago (2011-08-08 22:09:36 UTC) #13
commit-bot: I haz the power
Can't process patch for file chrome/browser/ui/webui/tracing_ui.cc. A +
9 years, 4 months ago (2011-08-08 22:14:13 UTC) #14
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 15:07:34 UTC) #15 
Can't process patch for file chrome/browser/ui/webui/tracing_ui.cc.
A +

Powered by Google App Engine
This is Rietveld 408576698