Issue 7553010: Fixed code generation for LBranch on ARM when the operand's representation is double.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7553010: Fixed code generation for LBranch on ARM when the operand's representation is double. (Closed)

Created:
9 years, 4 months ago by Sven Panne

Modified:
9 years, 4 months ago

Reviewers:
fschneider, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed code generation for LBranch on ARM when the operand's representation is double. The condition code for branching on the result of vcmp was wrong, effectively swapping the true/false branches. TEST=regress-lbranch-double.js Committed: http://code.google.com/p/v8/source/detail?r=8784

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1 line)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/compiler/regress-lbranch-double.js	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

This patch should probably be merged to some branches, too. Which ones exactly?

9 years, 4 months ago (2011-08-02 15:06:00 UTC) #1

LGTM

Expand Messages | Collapse Messages