Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 7553010: Fixed code generation for LBranch on ARM when the operand's representation is double. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-lbranch-double.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
1553 Register reg = ToRegister(instr->InputAt(0)); 1553 Register reg = ToRegister(instr->InputAt(0));
1554 __ cmp(reg, Operand(0)); 1554 __ cmp(reg, Operand(0));
1555 EmitBranch(true_block, false_block, ne); 1555 EmitBranch(true_block, false_block, ne);
1556 } else if (r.IsDouble()) { 1556 } else if (r.IsDouble()) {
1557 DoubleRegister reg = ToDoubleRegister(instr->InputAt(0)); 1557 DoubleRegister reg = ToDoubleRegister(instr->InputAt(0));
1558 Register scratch = scratch0(); 1558 Register scratch = scratch0();
1559 1559
1560 // Test the double value. Zero and NaN are false. 1560 // Test the double value. Zero and NaN are false.
1561 __ VFPCompareAndLoadFlags(reg, 0.0, scratch); 1561 __ VFPCompareAndLoadFlags(reg, 0.0, scratch);
1562 __ tst(scratch, Operand(kVFPZConditionFlagBit | kVFPVConditionFlagBit)); 1562 __ tst(scratch, Operand(kVFPZConditionFlagBit | kVFPVConditionFlagBit));
1563 EmitBranch(true_block, false_block, ne); 1563 EmitBranch(true_block, false_block, eq);
1564 } else { 1564 } else {
1565 ASSERT(r.IsTagged()); 1565 ASSERT(r.IsTagged());
1566 Register reg = ToRegister(instr->InputAt(0)); 1566 Register reg = ToRegister(instr->InputAt(0));
1567 if (instr->hydrogen()->value()->type().IsBoolean()) { 1567 if (instr->hydrogen()->value()->type().IsBoolean()) {
1568 __ LoadRoot(ip, Heap::kTrueValueRootIndex); 1568 __ LoadRoot(ip, Heap::kTrueValueRootIndex);
1569 __ cmp(reg, ip); 1569 __ cmp(reg, ip);
1570 EmitBranch(true_block, false_block, eq); 1570 EmitBranch(true_block, false_block, eq);
1571 } else { 1571 } else {
1572 Label* true_label = chunk_->GetAssemblyLabel(true_block); 1572 Label* true_label = chunk_->GetAssemblyLabel(true_block);
1573 Label* false_label = chunk_->GetAssemblyLabel(false_block); 1573 Label* false_label = chunk_->GetAssemblyLabel(false_block);
(...skipping 2911 matching lines...) Expand 10 before | Expand all | Expand 10 after
4485 ASSERT(osr_pc_offset_ == -1); 4485 ASSERT(osr_pc_offset_ == -1);
4486 osr_pc_offset_ = masm()->pc_offset(); 4486 osr_pc_offset_ = masm()->pc_offset();
4487 } 4487 }
4488 4488
4489 4489
4490 4490
4491 4491
4492 #undef __ 4492 #undef __
4493 4493
4494 } } // namespace v8::internal 4494 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-lbranch-double.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698