Adding simple filters to ChromeOS Image Editor.

Adding simple filters to ChromeOS Image Editor.

Added Autofix, Exposure, Blur, Sharpen.
Also improved appearance a bit by avoiding non-integer coordinates
and fixed W3C compatibility (a standalone demo now works on Opera
and Firefox allowing for performance comparisons).

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96384

[Vladislav Kaznacheev, 2011-08-10 09:56:55]

Please review.

[SeRya, 2011-08-10 13:00:20]

JSDoc types probably are misused. I thinks at least majority of lines like
{Number} should be {number}

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/image_editor/filter.js (right):

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/filter.js:13: * @param
{String} name Maps to a Filter method name.
Shouldn't it be "@param {string}" ?

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/filter.js:15: * @return
{Function} A closure to be called with 4 parameters:
@return {function(ImageData,ImageData,umber,number):void} ?

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/filter.js:37: * @param
{Number} maxPixelsPerStrip
{number}

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/image_editor/image_adjust.js
(right):

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:19: 
No new line needed.

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:133: 
New line

[Vladislav Kaznacheev, 2011-08-10 14:03:25]

Please take another look. I fixed @param declaration and did a small change in
Filter.convolve5x5 to better incapsulate scaling of values.

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/image_editor/filter.js (right):

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/filter.js:13: * @param
{String} name Maps to a Filter method name.
On 2011/08/10 13:00:20, SeRya wrote:
> Shouldn't it be "@param {string}" ?

Done.

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/filter.js:15: * @return
{Function} A closure to be called with 4 parameters:
On 2011/08/10 13:00:20, SeRya wrote:
> @return {function(ImageData,ImageData,umber,number):void} ?

Done.

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/filter.js:37: * @param
{Number} maxPixelsPerStrip
On 2011/08/10 13:00:20, SeRya wrote:
> {number}

Done.

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/image_editor/image_adjust.js
(right):

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:19: 
On 2011/08/10 13:00:20, SeRya wrote:
> No new line needed.

Done.

http://codereview.chromium.org/7552035/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:133: 
On 2011/08/10 13:00:20, SeRya wrote:
> New line

Done.

[SeRya, 2011-08-11 12:56:06]

LGTM with addressed comments.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/filter.js (right):

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/filter.js:6: * A namespace
class for image filter utilities.
Recomended way to declare namespace is:
var filter = {};

(all lower case letters)

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/image_adjust.js
(right):

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:7: * but
do not modify the image dimensions.
@constructor

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:19: 
New line

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:133: 
New line

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:156: *
Displays a histogram.
@constructor

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:193: * A
histogram container.
@constructor

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:277: *
Exposure/contrast filter.
@constructor

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:294: *
Autofix.
@constructor

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:313: *
Blur filter.
@constructor

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:330: *
Sharpen filter.
@constructor

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/image_editor.js
(right):

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:10: *
@param {function} closeCallback
Not sure about styleguide requirements but JS Compiler requires to specify
parameters. If it doesn't make sense {Function} should be used.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:48: *
@param {function} closeCallback
As above.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:396: 
Empty line

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:484: *
@param {String} name An option name.
{string}

[Vladislav Kaznacheev, 2011-08-11 14:04:36]

Thanks for the review, committing.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/filter.js (right):

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/filter.js:6: * A namespace
class for image filter utilities.
On 2011/08/11 12:56:06, SeRya wrote:
> Recomended way to declare namespace is:
> var filter = {};
> 
> (all lower case letters)

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/image_adjust.js
(right):

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:7: * but
do not modify the image dimensions.
On 2011/08/11 12:56:06, SeRya wrote:
> @constructor

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:19: 
Add or remove? This is a section comment, not JSDoc
On 2011/08/11 12:56:06, SeRya wrote:
> New line

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:133: 
Section comment.
On 2011/08/11 12:56:06, SeRya wrote:
> New line

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:156: *
Displays a histogram.
On 2011/08/11 12:56:06, SeRya wrote:
> @constructor

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:193: * A
histogram container.
On 2011/08/11 12:56:06, SeRya wrote:
> @constructor

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:277: *
Exposure/contrast filter.
On 2011/08/11 12:56:06, SeRya wrote:
> @constructor

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:294: *
Autofix.
On 2011/08/11 12:56:06, SeRya wrote:
> @constructor

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:313: *
Blur filter.
On 2011/08/11 12:56:06, SeRya wrote:
> @constructor

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_adjust.js:330: *
Sharpen filter.
On 2011/08/11 12:56:06, SeRya wrote:
> @constructor

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/image_editor.js
(right):

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:10: *
@param {function} closeCallback
On 2011/08/11 12:56:06, SeRya wrote:
> Not sure about styleguide requirements but JS Compiler requires to specify
> parameters. If it doesn't make sense {Function} should be used.

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:48: *
@param {function} closeCallback
On 2011/08/11 12:56:06, SeRya wrote:
> As above.

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:396: 
On 2011/08/11 12:56:06, SeRya wrote:
> Empty line

Done.

http://codereview.chromium.org/7552035/diff/5001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/image_editor.js:484: *
@param {String} name An option name.
On 2011/08/11 12:56:06, SeRya wrote:
> {string}

Done.