Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 7550025: Revert 95552 - Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a So... (Closed)

Created:
9 years, 4 months ago by yzshen1
Modified:
9 years, 4 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 95552 - Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserContext> instead of a Source<NavigationController>. We do this since SSLManagers want to hear all the notifications coming from different NavigationControllers; not just from the one they are associated with. BUG=87457 TEST=none R=abarth TBR=darin Review URL: http://codereview.chromium.org/7542029 Sorry about this. The tree stubbornly refuses to go green and yours is the only remaining patch in the blamelist. TBR=erg@google.com Review URL: http://codereview.chromium.org/7575035 TBR=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M content/browser/ssl/ssl_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_policy_backend.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/ssl/ssl_policy_backend.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM content/common/content_notification_types.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yzshen1
9 years, 4 months ago (2011-08-05 04:04:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698