Issue 7575035: Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserCon...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7575035: Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserCon... (Closed)

Created:
9 years, 4 months ago by apatrick_chromium

Modified:
9 years, 4 months ago

Reviewers:
erg

CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 95541 - Profiles: SSLManger broadcasts SSL_INTERNAL_STATE_CHANGED with a Source<BrowserContext> instead of a Source<NavigationController>. We do this since SSLManagers want to hear all the notifications coming from different NavigationControllers; not just from the one they are associated with. BUG=87457 TEST=none R=abarth TBR=darin Review URL: http://codereview.chromium.org/7542029 Sorry about this. The tree stubbornly refuses to go green and yours is the only remaining patch in the blamelist. TBR=erg@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95552

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -18 lines)			Patch
M	content/browser/ssl/ssl_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/ssl/ssl_manager.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	content/browser/ssl/ssl_policy_backend.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	content/browser/ssl/ssl_policy_backend.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
MM	content/common/content_notification_types.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages