Print Preview: Fixing behavior of event listeners.

chrome/browser/resources/print_preview/layout_settings.js

Index: chrome/browser/resources/print_preview/layout_settings.js
diff --git a/chrome/browser/resources/print_preview/layout_settings.js b/chrome/browser/resources/print_preview/layout_settings.js
index 0932e21c566de0c0363a9a1bb2e74a02ef767b6c..26897a5a7385af62374b4c2b13354f87b6bba00b 100644
--- a/chrome/browser/resources/print_preview/layout_settings.js
+++ b/chrome/browser/resources/print_preview/layout_settings.js
@@ -49,12 +49,10 @@ cr.define('print_preview', function() {
      */
     addEventListeners: function() {
       this.landscapeRadioButton_.onclick = function() {

[kmadhusu, 2011/08/08 22:20:45]

How about:
this.landscapeRadioButton_.onclick = this.onLayoutButtonClick_().bind(this); ? 

It will be consistent with page_settings.js line #338.

[dpapad, 2011/08/08 23:41:43]

Done.

-        if (!hasPendingPreviewRequest)
-          this.onLayoutButtonClick_();
+        this.onLayoutButtonClick_();
       }.bind(this);
       this.portraitRadioButton_.onclick = function() {
-        if (!hasPendingPreviewRequest)
-          this.onLayoutButtonClick_();
+        this.onLayoutButtonClick_();
       }.bind(this);
       document.addEventListener('PDFLoaded', this.onPDFLoaded_.bind(this));
       document.addEventListener('printerCapabilitiesUpdated',
@@ -87,8 +85,7 @@ cr.define('print_preview', function() {
      * @private
      */
     onPDFLoaded_: function() {
-      if (!previewModifiable)
-        fadeOutElement(this.layoutOption_);
+      this.fadeInOut_(!previewModifiable);
     },
 
     /**