Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2944)

Unified Diff: chrome/browser/resources/print_preview/color_settings.js

Issue 7550022: Print Preview: Fixing behavior of event listeners. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding new struct PrintHostMsg_DidGetPreviewPageCount_Params. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/color_settings.js
diff --git a/chrome/browser/resources/print_preview/color_settings.js b/chrome/browser/resources/print_preview/color_settings.js
index bb0198ceb4b8c3289fb04f5553c719df31f87065..c0547e90ea43ab39f624f49f7b67f88841a6cbfc 100644
--- a/chrome/browser/resources/print_preview/color_settings.js
+++ b/chrome/browser/resources/print_preview/color_settings.js
@@ -49,12 +49,10 @@ cr.define('print_preview', function() {
*/
addEventListeners: function() {
this.colorRadioButton_.onclick = function() {
kmadhusu 2011/08/08 22:20:45 Can you make this this.colorRadioButton_.onclick =
dpapad 2011/08/08 23:41:43 No this is syntactically wrong. setColor(true) doe
- if (!hasPendingPreviewRequest)
- setColor(true);
+ setColor(true);
};
this.bwRadioButton_.onclick = function() {
- if (!hasPendingPreviewRequest)
- setColor(false);
+ setColor(false);
};
document.addEventListener('PDFLoaded', this.onPDFLoaded_.bind(this));
document.addEventListener('printerCapabilitiesUpdated',

Powered by Google App Engine
This is Rietveld 408576698