Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issue 7548004: Remove a few unused functions. (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove a few unused functions. I temporarily enabled -Wunused-function in build/common.gypi, sent a tryjob to the linux clangbot, and fixed the fallout. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95097

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M net/base/x509_certificate.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M ppapi/proxy/ppb_core_proxy.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
rsleevi: net/ change dmichael: rest (both fallout from http://codereview.chromium.org/7349016 )
9 years, 4 months ago (2011-08-02 05:17:58 UTC) #1
Ryan Sleevi
net/ LGTM, but I'm not a net/ OWNER.
9 years, 4 months ago (2011-08-02 05:40:00 UTC) #2
Nico
Ah, the x509 in the filename made me think of crypto for some reason. eroman, ...
9 years, 4 months ago (2011-08-02 05:42:43 UTC) #3
eroman
LGTM
9 years, 4 months ago (2011-08-02 06:27:38 UTC) #4
dmichael (off chromium)
LGTM, thanks!
9 years, 4 months ago (2011-08-02 14:48:40 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-02 17:00:25 UTC) #6
Change committed as 95097

Powered by Google App Engine
This is Rietveld 408576698