Added versioning for PPB_Core::MemAlloc and MemFree

Removed MemAlloc and MemFree from PPB_Core


BUG=80610
TEST=Trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92554

[Matt Ball, 2011-07-12 19:07:34]

This is just a quick checkpoint so you can see what I've done so far.  No review
needed yet.

[dmichael (off chromium), 2011-07-12 19:10:27]

A little early feedback. Thanks for working on this!

http://codereview.chromium.org/7349016/diff/1/ppapi/c/ppb_core.h
File ppapi/c/ppb_core.h (right):

http://codereview.chromium.org/7349016/diff/1/ppapi/c/ppb_core.h#newcode17
ppapi/c/ppb_core.h:17: #ifdef PPAPI_INSTANCE_REMOVE_MEMALLOC
With Brett's change, we don't need the conditional compilation. Just make the
new one the default.

Also, go ahead and bump it to 1.0, or we'll have to do that in another CL.

http://codereview.chromium.org/7349016/diff/1/ppapi/c/ppb_core.h#newcode78
ppapi/c/ppb_core.h:78: void (*MemFree)(void* ptr);
Of course you'll want to remove these here.

[Matt Ball, 2011-07-12 23:15:26]

Thanks for the early feedback!  I've got a slightly more complete version that
I'm currently testing on the trybots.

Do you know how I build and test all of pepper from the chromium repository.  I
was just trying a couple guesses like 'make ppapi_proxy' and so forth.

Thanks!
-Matt

http://codereview.chromium.org/7349016/diff/1/ppapi/c/ppb_core.h
File ppapi/c/ppb_core.h (right):

http://codereview.chromium.org/7349016/diff/1/ppapi/c/ppb_core.h#newcode17
ppapi/c/ppb_core.h:17: #ifdef PPAPI_INSTANCE_REMOVE_MEMALLOC
On 2011/07/12 19:10:27, dmichael1 wrote:
> With Brett's change, we don't need the conditional compilation. Just make the
> new one the default.
> 
> Also, go ahead and bump it to 1.0, or we'll have to do that in another CL.

Done.

http://codereview.chromium.org/7349016/diff/1/ppapi/c/ppb_core.h#newcode78
ppapi/c/ppb_core.h:78: void (*MemFree)(void* ptr);
On 2011/07/12 19:10:27, dmichael1 wrote:
> Of course you'll want to remove these here.

Done.

[Matt Ball, 2011-07-13 19:58:44]

PTAL

I think it's ready for review now.

[dmichael (off chromium), 2011-07-14 05:28:21]

some suggestions/nits, but o/w LGTM

Great work!

http://codereview.chromium.org/7349016/diff/12001/ppapi/cpp/var.cc
File ppapi/cpp/var.cc (right):

http://codereview.chromium.org/7349016/diff/12001/ppapi/cpp/var.cc#newcode13
ppapi/cpp/var.cc:13: #include "ppapi/c/dev/ppb_memory_dev.h"
nit: This should probably come first alphabetically (though admittedly things
are already a bit off here

http://codereview.chromium.org/7349016/diff/12001/ppapi/example/example.cc
File ppapi/example/example.cc (right):

http://codereview.chromium.org/7349016/diff/12001/ppapi/example/example.cc#ne...
ppapi/example/example.cc:336: reinterpret_cast<PP_PrintOutputFormat_Dev*>(
optional: Since you're in the neighborhood, you could make that a static_cast

http://codereview.chromium.org/7349016/diff/12001/ppapi/proxy/ppb_core_proxy.cc
File ppapi/proxy/ppb_core_proxy.cc (right):

http://codereview.chromium.org/7349016/diff/12001/ppapi/proxy/ppb_core_proxy....
ppapi/proxy/ppb_core_proxy.cc:96: };
I'm not sure moving it here buys you much. I guess it's a little less exposed
(function scope instead of file scope), but it also makes it different from all
the other GetInfo functions. <shrug/>

[Matt Ball, 2011-07-14 15:49:20]

http://codereview.chromium.org/7349016/diff/12001/ppapi/cpp/var.cc
File ppapi/cpp/var.cc (right):

http://codereview.chromium.org/7349016/diff/12001/ppapi/cpp/var.cc#newcode13
ppapi/cpp/var.cc:13: #include "ppapi/c/dev/ppb_memory_dev.h"
On 2011/07/14 05:28:21, dmichael1 wrote:
> nit: This should probably come first alphabetically (though admittedly things
> are already a bit off here

Done.

http://codereview.chromium.org/7349016/diff/12001/ppapi/example/example.cc
File ppapi/example/example.cc (right):

http://codereview.chromium.org/7349016/diff/12001/ppapi/example/example.cc#ne...
ppapi/example/example.cc:336: reinterpret_cast<PP_PrintOutputFormat_Dev*>(
On 2011/07/14 05:28:21, dmichael1 wrote:
> optional: Since you're in the neighborhood, you could make that a static_cast

Done.

http://codereview.chromium.org/7349016/diff/12001/ppapi/proxy/ppb_core_proxy.cc
File ppapi/proxy/ppb_core_proxy.cc (right):

http://codereview.chromium.org/7349016/diff/12001/ppapi/proxy/ppb_core_proxy....
ppapi/proxy/ppb_core_proxy.cc:96: };
On 2011/07/14 05:28:21, dmichael1 wrote:
> I'm not sure moving it here buys you much. I guess it's a little less exposed
> (function scope instead of file scope), but it also makes it different from
all
> the other GetInfo functions. <shrug/>

Done.