chrome/renderer/print_web_view_helper_browsertest.cc - Issue 7544018: Print preview page selection should not require a rerendering of draft pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_browsertest.cc

Issue 7544018: Print preview page selection should not require a rerendering of draft pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove blank line Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/print_web_view_helper.cc ('K') | « chrome/renderer/print_web_view_helper.cc ('k') | chrome/renderer/print_web_view_helper_linux.cc » ('j') | chrome/renderer/print_web_view_helper_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/print_web_view_helper_browsertest.cc

diff --git a/chrome/renderer/print_web_view_helper_browsertest.cc b/chrome/renderer/print_web_view_helper_browsertest.cc

index d8977367c79a1912659041eaca75d8e4f772451a..c880043a2a5dc07efd0fb35262db75a747dba3bd 100644

--- a/chrome/renderer/print_web_view_helper_browsertest.cc

+++ b/chrome/renderer/print_web_view_helper_browsertest.cc

@@ -42,6 +42,7 @@ void CreatePrintSettingsDictionary(DictionaryValue* dict) {

dict->SetInteger(printing::kSettingCopies, 1);

dict->SetString(printing::kSettingDeviceName, "dummy");

dict->SetInteger(printing::kPreviewRequestID, 12345);

+ dict->SetBoolean(printing::kSettingGenerateDraftData, true);

vandebo (ex-Chrome) 2011/08/08 20:11:46 Should we create another test for generating the c

}

} // namespace

@@ -354,10 +355,8 @@ TEST_F(PrintWebViewHelperPreviewTest, OnPrintPreview) {

// Need to finish simulating print preview.

// Generate the page and finalize it.

- PrintWebViewHelper::Get(view_)->OnContinuePreview(

- printing::INVALID_PAGE_INDEX);

- PrintWebViewHelper::Get(view_)->OnContinuePreview(

- printing::INVALID_PAGE_INDEX);

+ PrintWebViewHelper::Get(view_)->OnContinuePreview();

EXPECT_EQ(0, render_thread_.print_preview_pages_remaining());

VerifyPrintPreviewFailed(false);