Print preview page selection should not require a rerendering of draft pages.

chrome/renderer/print_web_view_helper_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/print_messages.h"
 #include "chrome/renderer/print_web_view_helper.h"
 #include "chrome/test/base/render_view_test.h"
 #include "printing/print_job_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 24 matching lines @@
 
 void CreatePrintSettingsDictionary(DictionaryValue* dict) {
   dict->SetBoolean(printing::kSettingLandscape, false);
   dict->SetBoolean(printing::kSettingCollate, false);
   dict->SetBoolean(printing::kSettingColor, false);
   dict->SetBoolean(printing::kSettingPrintToPDF, true);
   dict->SetInteger(printing::kSettingDuplexMode, printing::SIMPLEX);
   dict->SetInteger(printing::kSettingCopies, 1);
   dict->SetString(printing::kSettingDeviceName, "dummy");
   dict->SetInteger(printing::kPreviewRequestID, 12345);
+  dict->SetBoolean(printing::kSettingGenerateDraftData, true);

[vandebo (ex-Chrome), 2011/08/08 20:11:46]

Should we create another test for generating the complete metafile only (without
draft pages)?

 }
 
 }  // namespace
 
 class PrintWebViewHelperTestBase : public RenderViewTest {
  public:
   PrintWebViewHelperTestBase() {}
   ~PrintWebViewHelperTestBase() {}
 
  protected:
@@ skipping 292 matching lines @@
   LoadHTML(kHelloWorldHTML);
 
   PrintWebViewHelper::Get(view_)->OnInitiatePrintPreview();
   // Fill in some dummy values.
   DictionaryValue dict;
   CreatePrintSettingsDictionary(&dict);
   PrintWebViewHelper::Get(view_)->OnPrintPreview(dict);
 
   // Need to finish simulating print preview.
   // Generate the page and finalize it.
-  PrintWebViewHelper::Get(view_)->OnContinuePreview(
-      printing::INVALID_PAGE_INDEX);
-  PrintWebViewHelper::Get(view_)->OnContinuePreview(
-      printing::INVALID_PAGE_INDEX);
+  PrintWebViewHelper::Get(view_)->OnContinuePreview();
+  PrintWebViewHelper::Get(view_)->OnContinuePreview();
 
   EXPECT_EQ(0, render_thread_.print_preview_pages_remaining());
   VerifyPrintPreviewFailed(false);
   VerifyPrintPreviewGenerated(true);
   VerifyPagesPrinted(false);
 }
 
 // Tests that print preview fails and receiving error messages through
 // that channel all works.
 TEST_F(PrintWebViewHelperPreviewTest, OnPrintPreviewFail) {
@@ skipping 30 matching lines @@
   LoadHTML(kPrintPreviewHTML);
 
   // An empty dictionary should fail.
   DictionaryValue empty_dict;
   PrintWebViewHelper::Get(view_)->OnPrintForPrintPreview(empty_dict);
 
   VerifyPrintFailed(true);
   VerifyPagesPrinted(false);
 }
 #endif  // !defined(OS_CHROMEOS)