Issue 7542027: Reland 'Show crashed apps on NTP, desaturated. Click to reload.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7542027: Reland 'Show crashed apps on NTP, desaturated. Click to reload.' (Closed)

Created:
9 years, 4 months ago by Yoyo Zhou

Modified:
9 years, 4 months ago

Reviewers:
jstritar, Evan Stade

CC:
chromium-reviews, Erik does not do reviews, kkania, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland 'Show crashed apps on NTP, desaturated. Click to reload.' Refactor CreateAppInfo less, since pyauto functional tests for the NTP expect it to still return something for special apps like the Webstore. original CL at http://codereview.chromium.org/7517019 reverted CL at http://codereview.chromium.org/7553001 BUG=90433 TEST=Crash a packaged app with a background page. It appears on the NTP, and clicking its icon relaunches it. ntp pyauto functional tests also pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95348

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -68 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.cc	View	2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/extension_icon_source.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.h	View	2 3	2 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	1 2 3 4	26 chunks	+81 lines, -61 lines	0 comments	Download

Total messages: 4 (0 generated)

Evan Stade

can you do a diff relative to the old patch so it's easy to see ...

9 years, 4 months ago (2011-08-02 22:26:41 UTC) #2

Yoyo Zhou

On 2011/08/02 22:26:41, Evan Stade wrote: > can you do a diff relative to the ...

9 years, 4 months ago (2011-08-02 23:59:55 UTC) #3

lgtm