Issue 7553001: Revert 95009. Causing pyauto NTP test failures on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7553001: Revert 95009. Causing pyauto NTP test failures on all platforms. (Closed)

Created:
9 years, 4 months ago by kkania

Modified:
9 years, 4 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Erik does not do reviews, kkania, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 95009. Causing pyauto NTP test failures on all platforms. Original CL: - Show crashed apps on NTP, desaturated. Click to reload. Also refactored CreateAppInfo a bit. BUG=90433 TEST=Crash a packaged app with a background page. It appears on the NTP, and clicking its icon relaunches it. Review URL: http://codereview.chromium.org/7517019 TBR=yoz@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95023

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -93 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/extension_icon_source.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	28 chunks	+73 lines, -82 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kkania

9 years, 4 months ago (2011-08-02 01:30:43 UTC) #3

example test failure:


======================================================================
FAIL: ntp.NTPTest.testGetAppsInNewProfile: "Ensures that the only app in a new
profile is the Web Store app."
----------------------------------------------------------------------
Traceback (most recent call last):
  File "E:\b\build\slave\Win_Vista\build\src\chrome\test\functional\ntp.py",
line 383, in testGetAppsInNewProfile
    self._VerifyAppInfo(app_info, self._EXPECTED_DEFAULT_APPS)
  File "E:\b\build\slave\Win_Vista\build\src\chrome\test\functional\ntp.py",
line 356, in _VerifyAppInfo
    len(expected_info), len(actual_info)))
AssertionError: Expected 2 app(s) on NTP, but got 0 instead.

Expand Messages | Collapse Messages