Issue 7541056: Toggle a multiple select option instead of setting it as selected when

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7541056: Toggle a multiple select option instead of setting it as selected when (Closed)

Created:
9 years, 4 months ago by kkania

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Huyen

CC:
chromium-reviews, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Toggle a multiple select option instead of setting it as selected when clicking. BUG=90994 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96052

Patch Set 2 : ... #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -19 lines)			Patch
M	chrome/test/webdriver/commands/mouse_commands.cc	View		2 chunks	+33 lines, -1 line	0 comments	Download
M	chrome/test/webdriver/commands/webelement_commands.cc	View	1	1 chunk	+6 lines, -11 lines	0 comments	Download
M	chrome/test/webdriver/session.h	View		1 chunk	+14 lines, -2 lines	0 comments	Download
M	chrome/test/webdriver/session.cc	View		2 chunks	+35 lines, -3 lines	0 comments	Download
M	chrome/test/webdriver/test/WEBDRIVER_TESTS	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Huyen

lgtm http://codereview.chromium.org/7541056/diff/1/chrome/test/webdriver/commands/webelement_commands.cc File chrome/test/webdriver/commands/webelement_commands.cc (right): http://codereview.chromium.org/7541056/diff/1/chrome/test/webdriver/commands/webelement_commands.cc#newcode338 chrome/test/webdriver/commands/webelement_commands.cc:338: Error* error =session_->IsOptionElementSelected( add space after "="

9 years, 4 months ago (2011-08-08 21:05:21 UTC) #2

Change committed as 96052

Expand Messages | Collapse Messages

Issue 7541056: Toggle a multiple select option instead of setting it as selected when (Closed)

Description

Patch Set 1 #

Patch Set 2 : ... #

Messages