Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10425)

Unified Diff: chrome/test/webdriver/commands/webelement_commands.cc

Issue 7541056: Toggle a multiple select option instead of setting it as selected when (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/mouse_commands.cc ('k') | chrome/test/webdriver/session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/webelement_commands.cc
diff --git a/chrome/test/webdriver/commands/webelement_commands.cc b/chrome/test/webdriver/commands/webelement_commands.cc
index 561bd5303764624a9103eca125c58416985e9a32..c76c66b6e7e7a2b0fed7e4dae7bcc8b5e30da3cc 100644
--- a/chrome/test/webdriver/commands/webelement_commands.cc
+++ b/chrome/test/webdriver/commands/webelement_commands.cc
@@ -334,24 +334,19 @@ bool ElementSelectedCommand::DoesPost() {
}
void ElementSelectedCommand::ExecuteGet(Response* const response) {
- ListValue args;
- args.Append(element.ToValue());
-
- std::string script = base::StringPrintf(
- "return (%s).apply(null, arguments);", atoms::IS_SELECTED);
-
- Value* result = NULL;
- Error* error = session_->ExecuteScript(script, &args, &result);
+ bool is_selected;
+ Error* error = session_->IsOptionElementSelected(
+ session_->current_target(), element, &is_selected);
if (error) {
response->SetError(error);
return;
}
- response->SetValue(result);
+ response->SetValue(Value::CreateBooleanValue(is_selected));
}
void ElementSelectedCommand::ExecutePost(Response* const response) {
- Error* error = session_->SelectOptionElement(
- session_->current_target(), element);
+ Error* error = session_->SetOptionElementSelected(
+ session_->current_target(), element, true);
if (error) {
response->SetError(error);
return;
« no previous file with comments | « chrome/test/webdriver/commands/mouse_commands.cc ('k') | chrome/test/webdriver/session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698