DevTools: no way to remote debug using ToT build as a client.

DevTools: no way to remote debug using ToT build as a client.
(rebaselined and brushed up loislo's http://codereview.chromium.org/7482041)

BUG=90743
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95138

[yurys, 2011-08-01 13:42:29]

http://codereview.chromium.org/7540023/diff/1/net/server/web_socket.cc
File net/server/web_socket.cc (right):

http://codereview.chromium.org/7540023/diff/1/net/server/web_socket.cc#newcode29
net/server/web_socket.cc:29: static uint32 WebSocketKeyFingerprint(const
std::string& str) {
Consider splitting this class into two files with Hixies76 and Hybi10
implementations.

http://codereview.chromium.org/7540023/diff/1/net/server/web_socket.h
File net/server/web_socket.h (right):

http://codereview.chromium.org/7540023/diff/1/net/server/web_socket.h#newcode36
net/server/web_socket.h:36: WebSocket(HttpConnection* connection);
"explicit" modifier is missing.

[yurys, 2011-08-01 13:51:09]

http://codereview.chromium.org/7540023/diff/1/net/server/web_socket.cc
File net/server/web_socket.cc (right):

http://codereview.chromium.org/7540023/diff/1/net/server/web_socket.cc#newcod...
net/server/web_socket.cc:246: static const uint64 max_payload_ength =
0x7FFFFFFFFFFFFFFFull;
max_payload_ength -> max_payload_length

[yurys, 2011-08-01 14:00:00]

lgtm given that the remote debugging functionality is broken and we need to fix
that ASAP but we definitely need a test for remote debugging to avoid such
situations in future.

[eroman, 2011-08-02 19:01:33]

LGTM

http://codereview.chromium.org/7540023/diff/5001/net/server/http_connection.h
File net/server/http_connection.h (right):

http://codereview.chromium.org/7540023/diff/5001/net/server/http_connection.h...
net/server/http_connection.h:37: static int lastId_;
last_id_

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.cc
File net/server/web_socket.cc (right):

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.cc#new...
net/server/web_socket.cc:31: const char* pChar = str.c_str();
please change this name to match styleguide.

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.cc#new...
net/server/web_socket.cc:191: static const char* const web_socket_GUID =
kWebSocketGuid

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.cc#new...
net/server/web_socket.cc:226: CHECK(op_code_ == kOpCodeText);
check_eq

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.cc#new...
net/server/web_socket.cc:265: (*message)[i] = payload[i] ^ masking_key[i %
kMaskingKeyWidthInBytes];
I only did a cursory review of this logic BTW

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.h
File net/server/web_socket.h (right):

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.h#newc...
net/server/web_socket.h:25: enum ParseResult {
nit: move this to top

http://codereview.chromium.org/7540023/diff/5001/net/server/web_socket.h#newc...
net/server/web_socket.h:34: 
Please add a virtual destructor (with empty body) to prevent accidental leaks.