Issue 7539010: Emit immediate call arguments locally to save stack size when compiling with -O0

Issue 7539010: Emit immediate call arguments locally to save stack size when compiling with -O0 (Closed)

Created:
9 years, 4 months ago by krasin

Modified:
9 years, 4 months ago

Reviewers:
nlewycky

Base URL:
http://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 1 : Emit immediate call arguments locally to save stack size when compiling with -O0 #

Patch Set 3 : Add a separate test for x86-64 case. Revert the common test. #

Patch Set 4 : Remove an empty line #

Total comments: 4

Patch Set 5 : Remove commented code and add the comment to the test about merging #

Patch Set 6 : Add EOL at the end of test file. #

Patch Set 7 : Merge test with the existing one #

Patch Set 8 : fix several typos #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -10 lines)			Patch
	M	lib/Target/X86/X86FastISel.cpp	View	1 2 3 4 5 6	3 chunks	+14 lines, -9 lines	0 comments	Download
	M	test/CodeGen/X86/fast-isel-x86-64.ll	View	1 2 3 4 5 6 7	1 chunk	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

krasin

On 2011/07/30 01:30:35, krasin wrote: This is the output from make check -j16: Testing Time: ...

9 years, 4 months ago (2011-07-30 01:31:13 UTC) #2

nlewycky

Please also add a test under test/... On 2011/07/30 01:31:13, krasin wrote: > On 2011/07/30 ...

9 years, 4 months ago (2011-07-30 01:33:33 UTC) #3

nlewycky

On 2011/08/01 20:44:53, krasin wrote: > Please, take another look.

9 years, 4 months ago (2011-08-01 20:49:23 UTC) #5

nlewycky

http://codereview.chromium.org/7539010/diff/7002/lib/Target/X86/X86FastISel.cpp File lib/Target/X86/X86FastISel.cpp (right): http://codereview.chromium.org/7539010/diff/7002/lib/Target/X86/X86FastISel.cpp#newcode1590 lib/Target/X86/X86FastISel.cpp:1590: // ArgReg = getRegForValue(ArgVal); Don't send out a patch ...

9 years, 4 months ago (2011-08-01 20:49:28 UTC) #6

krasin

9 years, 4 months ago (2011-08-01 20:55:37 UTC) #7

http://codereview.chromium.org/7539010/diff/7002/lib/Target/X86/X86FastISel.cpp
File lib/Target/X86/X86FastISel.cpp (right):

http://codereview.chromium.org/7539010/diff/7002/lib/Target/X86/X86FastISel.c...
lib/Target/X86/X86FastISel.cpp:1590: //      ArgReg = getRegForValue(ArgVal);
On 2011/08/01 20:49:28, nlewycky wrote:
> Don't send out a patch with a commented-out line.
Shame on me!
Done.

http://codereview.chromium.org/7539010/diff/7002/test/CodeGen/X86/fast-isel-c...
File test/CodeGen/X86/fast-isel-call-x86-64.ll (right):

http://codereview.chromium.org/7539010/diff/7002/test/CodeGen/X86/fast-isel-c...
test/CodeGen/X86/fast-isel-call-x86-64.ll:2: 
On 2011/08/01 20:49:28, nlewycky wrote:
> Please add a comment that you'd like this to be folded into
fast-isel-call-x86,
> but can't due to lack of FastISel for llvm.memcpy and llvm.memset.

Done.

Expand Messages | Collapse Messages