Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 7539008: Add a PKCS#12 file with a certificate but no private key (Closed)

Created:
9 years, 4 months ago by gauravsh
Modified:
9 years, 4 months ago
Reviewers:
wtc, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[Replaced by http://codereview.chromium.org/7466044 ] Add a PKCS#12 file with a certificate but no private key This is needed for a unit test used in a separate CL. (http://codereview.chromium.org/7466006) TBR=wtc BUG=chromium-os:15838 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/data/ssl/certificates/README View 1 chunk +3 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/client-nokey.p12 View Binary file 0 comments Download

Messages

Total messages: 12 (0 generated)
gauravsh
Since the trybots do not handle binary blobs, here's the test data addition as a ...
9 years, 4 months ago (2011-07-30 00:08:31 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 4 months ago (2011-07-30 01:12:34 UTC) #2
Ryan Sleevi
LGTM
9 years, 4 months ago (2011-07-30 01:12:37 UTC) #3
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 4 months ago (2011-07-30 01:12:54 UTC) #4
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
9 years, 4 months ago (2011-07-30 01:13:16 UTC) #5
Ryan Sleevi
Blah. This will need to be manually committed. My tree is pretty messy at the ...
9 years, 4 months ago (2011-07-30 01:14:46 UTC) #6
wtc
LGTM.
9 years, 4 months ago (2011-07-30 05:13:54 UTC) #7
Ryan Sleevi
Unless I'm missing something critical, I don't have a way to download the raw binary ...
9 years, 4 months ago (2011-07-31 00:17:56 UTC) #8
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
9 years, 4 months ago (2011-07-31 20:25:44 UTC) #9
gauravsh
On 2011/07/31 00:17:56, Ryan Sleevi wrote: > Unless I'm missing something critical, I don't have ...
9 years, 4 months ago (2011-07-31 20:26:39 UTC) #10
wtc
gauravsh: Yes, please email me the binary file client-nokey.p12. Are you not a Chromium committer?
9 years, 4 months ago (2011-08-01 17:14:50 UTC) #11
wtc
9 years, 4 months ago (2011-08-03 16:31:21 UTC) #12
gauravsh: I have created another CL http://codereview.chromium.org/7466044
and checked it in for you.

Powered by Google App Engine
This is Rietveld 408576698