Windows Breakpad: Allow the crash dump dir and pipe name to be overridden

Windows Breakpad: Allow the crash dump dir and pipe name to be overridden

Change crash_service.exe so that the named pipe it listens on
(normally global) and the directory it writes to (normally per-user)
can both be overridden via command line options.

Similarly, add an environment variable to Chromium for connecting to
crash_service.exe via a non-default named pipe.

This will allow automated tests of Chromium's Breakpad crash reporting
to be more robust.  A test runner can use a temp dir for crashes and a
temporary named pipe, so that it does not have to worry about
pre-existing instances of crash_service.exe or pre-existing dump
files.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2006
TEST=inbrowser_crash_test in the NaCl tree, with the change http://codereview.chromium.org/7569002

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95714

[Mark Seaborn, 2011-08-03 18:30:16]

Hi Carlos, I'm guessing you'd be a good reviewer for Windows Breakpad changes.

[cpu_(ooo_6.6-7.5), 2011-08-03 22:38:48]

lgtm

http://codereview.chromium.org/7538036/diff/3001/chrome/app/breakpad_win.cc
File chrome/app/breakpad_win.cc (right):

http://codereview.chromium.org/7538036/diff/3001/chrome/app/breakpad_win.cc#n...
chrome/app/breakpad_win.cc:523: if (env_var != NULL) {
please use GetEnvironmentVariable() which returns wchar or
chrome/src/base/environment.h

[Mark Seaborn, 2011-08-04 00:31:51]

On 3 August 2011 15:38, <cpu@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.**org/7538036/diff/3001/chrome/**
>
app/breakpad_win.cc<http://codereview.chromium.org/7538036/diff/3001/chrome/app/breakpad_win.cc>
> File chrome/app/breakpad_win.cc (right):
>
> http://codereview.chromium.**org/7538036/diff/3001/chrome/**
>
app/breakpad_win.cc#newcode523<http://codereview.chromium.org/7538036/diff/3001/chrome/app/breakpad_win.cc#newcode523>
> chrome/app/breakpad_win.cc:**523: if (env_var != NULL) {
> please use GetEnvironmentVariable() which returns wchar or
> chrome/src/base/environment.h
>

OK, changed to use GetEnvironmentVariableW().  I looked at
chrome/src/base/environment.h earlier, but it doesn't return a wchar string
so the same awkward conversion construct would be needed for that.

Do you think I should use a command line switch instead and add it to
chrome/common/chrome_switches.h?

Mark

[cpu_(ooo_6.6-7.5), 2011-08-05 19:56:02]

On 2011/08/04 00:31:51, Mark Seaborn wrote:
> On 3 August 2011 15:38, <mailto:cpu@chromium.org> wrote:
> 
> > lgtm
> >
> >
> > http://codereview.chromium.**org/7538036/diff/3001/chrome/**
> >
>
app/breakpad_win.cc<http://codereview.chromium.org/7538036/diff/3001/chrome/app/breakpad_win.cc>
> > File chrome/app/breakpad_win.cc (right):
> >
> > http://codereview.chromium.**org/7538036/diff/3001/chrome/**
> >
>
app/breakpad_win.cc#newcode523<http://codereview.chromium.org/7538036/diff/3001/chrome/app/breakpad_win.cc#newcode523>
> > chrome/app/breakpad_win.cc:**523: if (env_var != NULL) {
> > please use GetEnvironmentVariable() which returns wchar or
> > chrome/src/base/environment.h
> >
> 
> OK, changed to use GetEnvironmentVariableW().  I looked at
> chrome/src/base/environment.h earlier, but it doesn't return a wchar string
> so the same awkward conversion construct would be needed for that.
> 
> Do you think I should use a command line switch instead and add it to
> chrome/common/chrome_switches.h?
> 

I Like this approach better.

> Mark

[cpu_(ooo_6.6-7.5), 2011-08-06 00:48:57]

lgtm

[commit-bot: I haz the power, 2011-08-06 01:54:47]

Change committed as 95714