Windows Breakpad: Allow the crash dump dir and pipe name to be overridden

chrome/tools/crash_service/crash_service.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/tools/crash_service/crash_service.h"
 
 #include <windows.h>
 
 #include <fstream>
 #include <map>
@@ skipping 131 matching lines @@
       : pid(process_id), self(service), map(crash_map), dump_path(path) {
   }
 };
 
 }  // namespace
 
 // Command line switches:
 const char CrashService::kMaxReports[]  = "max-reports";
 const char CrashService::kNoWindow[]    = "no-window";
 const char CrashService::kReporterTag[] = "reporter";
+const char CrashService::kDumpsDir[]    = "dumps-dir";
+const char CrashService::kPipeName[]    = "pipe-name";
 
 CrashService::CrashService(const std::wstring& report_dir)
     : report_path_(report_dir),
       sender_(NULL),
       dumper_(NULL),
       requests_handled_(0),
       requests_sent_(0),
       clients_connected_(0),
       clients_terminated_(0) {
   chrome::RegisterPathProvider();
 }
 
 CrashService::~CrashService() {
   base::AutoLock lock(sending_);
   delete dumper_;
   delete sender_;
 }
 
 
 bool CrashService::Initialize(const std::wstring& command_line) {
   using google_breakpad::CrashReportSender;
   using google_breakpad::CrashGenerationServer;
 
-  const wchar_t* pipe_name = kTestPipeName;
+  std::wstring pipe_name = kTestPipeName;
   int max_reports = -1;
 
   // The checkpoint file allows CrashReportSender to enforce the the maximum
   // reports per day quota. Does not seem to serve any other purpose.
   FilePath checkpoint_path = report_path_.Append(kCheckPointFile);
 
   // The dumps path is typically : '<user profile>\Local settings\
   // Application data\Goggle\Chrome\Crash Reports' and the report path is
   // Application data\Google\Chrome\Reported Crashes.txt
   FilePath user_data_dir;
   if (!PathService::Get(chrome::DIR_USER_DATA, &user_data_dir)) {
     LOG(ERROR) << "could not get DIR_USER_DATA";
     return false;
   }
   report_path_ = user_data_dir.Append(chrome::kCrashReportLog);
 
+  CommandLine cmd_line = CommandLine::FromString(command_line);
+
   FilePath dumps_path;
-  if (!PathService::Get(chrome::DIR_CRASH_DUMPS, &dumps_path)) {
-    LOG(ERROR) << "could not get DIR_CRASH_DUMPS";
-    return false;
+  if (cmd_line.HasSwitch(kDumpsDir)) {
+    dumps_path = FilePath(cmd_line.GetSwitchValueNative(kDumpsDir));
+  } else {
+    if (!PathService::Get(chrome::DIR_CRASH_DUMPS, &dumps_path)) {
+      LOG(ERROR) << "could not get DIR_CRASH_DUMPS";
+      return false;
+    }
   }
 
-  CommandLine cmd_line = CommandLine::FromString(command_line);
-
   // We can override the send reports quota with a command line switch.
   if (cmd_line.HasSwitch(kMaxReports))
     max_reports = _wtoi(cmd_line.GetSwitchValueNative(kMaxReports).c_str());
 
+  // Allow the global pipe name to be overridden for better testability.
+  if (cmd_line.HasSwitch(kPipeName))
+    pipe_name = cmd_line.GetSwitchValueNative(kPipeName);
+
   if (max_reports > 0) {
     // Create the http sender object.
     sender_ = new CrashReportSender(checkpoint_path.value());
     if (!sender_) {
       LOG(ERROR) << "could not create sender";
       return false;
     }
     sender_->set_max_reports_per_day(max_reports);
   }
 
@@ skipping 256 matching lines @@
                                                              SDDL_REVISION,
                                                              &sec_desc, NULL)) {
     if (::GetSecurityDescriptorSacl(sec_desc, &sacl_present, &sacl,
                                     &sacl_defaulted)) {
       return sec_desc;
     }
   }
 
   return NULL;
 }