Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove underscore. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 67e7fe540c9874c645b7319b9d1a4c9b5dc96119..695098046b5918747961c5c4901b1d19f27e8717 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -328,6 +328,9 @@ class BrowserWindow {
virtual WindowOpenDisposition GetDispositionForPopupBounds(
const gfx::Rect& bounds) = 0;
+ // Construct a FindBar implementation for the |browser|.
+ virtual FindBar* CreateFindBar() = 0;
+
#if defined(OS_CHROMEOS)
// Shows the keyboard overlay dialog box.
virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) = 0;
@@ -336,9 +339,6 @@ class BrowserWindow {
// Construct a BrowserWindow implementation for the specified |browser|.
static BrowserWindow* CreateBrowserWindow(Browser* browser);
- // Construct a FindBar implementation for the specified |browser|.
- static FindBar* CreateFindBar(Browser* browser_window);
-
protected:
friend class BrowserList;
friend class BrowserView;

Powered by Google App Engine
This is Rietveld 408576698