Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels.

chrome/browser/ui/panels/panel_window_controller_cocoa.h

Index: chrome/browser/ui/panels/panel_window_controller_cocoa.h
diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.h b/chrome/browser/ui/panels/panel_window_controller_cocoa.h
index 6448d68c5ff98ed18b2776e56e9a283900e3c541..3c68ae2fae0d0cff7b4fcdfcaa7a23489cbfec9e 100644
--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.h
+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.h
@@ -14,6 +14,7 @@
 #import "base/mac/cocoa_protocols.h"
 #include "base/memory/scoped_ptr.h"
 
+@class FindBarCocoaController;
 class PanelBrowserWindowCocoa;
 @class PanelTitlebarViewCocoa;
 
@@ -21,6 +22,7 @@ class PanelBrowserWindowCocoa;
  @private
   IBOutlet PanelTitlebarViewCocoa* titlebar_view_;
   scoped_ptr<PanelBrowserWindowCocoa> windowShim_;
+  scoped_nsobject<FindBarCocoaController> findBarCocoaController_;

[Dmitry Titov, 2011/08/01 19:57:48]

Why do we need to retain the controller here? I think this is to release the
controller when the Panel is closed. I wonder if we can simply hang on the views
hierarchy here, w/o having this pointer for lifetime purposes.
At least this has to be documented. A comment right here that explains why we
retain the controller would be useful.

 }
 
 // Load the browser window nib and do any Cocoa-specific initialization.
@@ -39,6 +41,10 @@ class PanelBrowserWindowCocoa;
 // Shows the window for the first time. Only happens once.
 - (void)revealAnimatedWithFrame:(const NSRect&)frame;
 
+// Retains the given FindBarCocoaController and adds its view to this
+// Panel. Must only be called once per PanelWindowControllerCocoa.
+- (void)addFindBar:(FindBarCocoaController*)findBarCocoaController;
+
 // Initiate the closing of the panel, starting from the platform-independent
 // layer. This will take care of PanelManager, other panels and close the
 // native window at the end.