chrome/browser/ui/panels/panel_browsertest.cc - Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 7538010: Make BrowserWindow::CreateFindBar non-static so that it can be overridden by Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Also change TestBrowserWindow Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/native_panel.h ('K') | « chrome/browser/ui/panels/panel_browser_window_gtk.cc ('k') | chrome/browser/ui/panels/panel_window_controller_cocoa.h » ('j') | chrome/browser/ui/panels/panel_window_controller_cocoa.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_browsertest.cc

diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc

index 3e76af96ecb8fc8fe48c34f0ebb7da3af4e2fb69..2effbe1260910036f9472768752c9a48c38786b9 100644

--- a/chrome/browser/ui/panels/panel_browsertest.cc

+++ b/chrome/browser/ui/panels/panel_browsertest.cc

@@ -10,6 +10,8 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/find_bar/find_bar.h"

+#include "chrome/browser/ui/find_bar/find_bar_controller.h"

#include "chrome/browser/ui/panels/panel.h"

#include "chrome/browser/ui/panels/panel_manager.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

@@ -159,6 +161,14 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, CreatePanel) {

EXPECT_EQ(0, panel_manager->num_panels());

}

+IN_PROC_BROWSER_TEST_F(PanelBrowserTest, FindBar) {

+ Panel* panel = CreatePanel("PanelTest", gfx::Rect(0, 0, 400, 400));

+ Browser* browser = panel->browser();

+ browser->ShowFindBar();

+ ASSERT_TRUE(browser->GetFindBarController()->find_bar()->IsFindBarVisible());

+ panel->Close();

// TODO(jianli): Investigate and enable it for Mac.

#ifdef OS_MACOSX

#define MAYBE_CreatePanelOnOverflow DISABLED_CreatePanelOnOverflow