Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 7537030: Make panel adjust bounds per preferred size change notification on Windows. (Closed)

Created:
9 years, 4 months ago by jianli
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Avi (use Gerrit), jennb, brettw-cc_chromium.org, jam, dcheng, prasadt, joi+watch-content_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make panel adjust bounds per preferred size change notification on Windows. BUG=none TEST=new browser test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99880

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 20

Patch Set 3 : '' #

Total comments: 8

Patch Set 4 : '' #

Total comments: 6

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Total comments: 2

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -64 lines) Patch
M chrome/browser/extensions/extension_host.h View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 3 4 5 6 7 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/native_panel.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 2 3 4 5 6 7 6 chunks +38 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 2 3 4 5 6 7 5 chunks +77 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 2 3 4 5 6 7 5 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 1 2 3 4 5 6 7 4 chunks +61 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.mm View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.cc View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.h View 1 2 3 4 5 6 7 4 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 1 2 3 4 5 6 7 8 chunks +106 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_touch.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_touch.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
A chrome/test/data/update-preferred-size.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/test_tab_contents_view.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_tab_contents_view.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
jianli
9 years, 4 months ago (2011-08-01 19:47:27 UTC) #1
jianli
Please review again. Thanks.
9 years, 4 months ago (2011-08-05 00:45:52 UTC) #2
Dmitry Titov
Wohoo! http://codereview.chromium.org/7537030/diff/7001/chrome/browser/ui/browser_window.h File chrome/browser/ui/browser_window.h (right): http://codereview.chromium.org/7537030/diff/7001/chrome/browser/ui/browser_window.h#newcode337 chrome/browser/ui/browser_window.h:337: // Invoked when the preferred size of the ...
9 years, 4 months ago (2011-08-05 19:02:20 UTC) #3
jianli
http://codereview.chromium.org/7537030/diff/7001/chrome/browser/ui/browser_window.h File chrome/browser/ui/browser_window.h (right): http://codereview.chromium.org/7537030/diff/7001/chrome/browser/ui/browser_window.h#newcode337 chrome/browser/ui/browser_window.h:337: // Invoked when the preferred size of the contents ...
9 years, 4 months ago (2011-08-09 19:56:15 UTC) #4
Dmitry Titov
Thanks! Almost there. http://codereview.chromium.org/7537030/diff/15001/chrome/browser/ui/panels/native_panel.h File chrome/browser/ui/panels/native_panel.h (right): http://codereview.chromium.org/7537030/diff/15001/chrome/browser/ui/panels/native_panel.h#newcode66 chrome/browser/ui/panels/native_panel.h:66: // Returns the size of the ...
9 years, 4 months ago (2011-08-09 21:08:15 UTC) #5
jianli
http://codereview.chromium.org/7537030/diff/15001/chrome/browser/ui/panels/native_panel.h File chrome/browser/ui/panels/native_panel.h (right): http://codereview.chromium.org/7537030/diff/15001/chrome/browser/ui/panels/native_panel.h#newcode66 chrome/browser/ui/panels/native_panel.h:66: // Returns the size of the non-client area, that ...
9 years, 4 months ago (2011-08-09 22:15:49 UTC) #6
Dmitry Titov
lgtm with a note: On 2011/08/09 22:15:49, jianli wrote: > > I wonder why don't ...
9 years, 4 months ago (2011-08-09 22:44:27 UTC) #7
jianli
On Tue, Aug 9, 2011 at 3:44 PM, <dimich@chromium.org> wrote: > lgtm > > with ...
9 years, 4 months ago (2011-08-09 22:50:11 UTC) #8
Dmitry Titov
> > For now, native_panel() is only exposed for testing. Do we want to remove ...
9 years, 4 months ago (2011-08-09 23:53:40 UTC) #9
jianli
Brett or John, can you look at my changes I did at content/browser/tab_contents?
9 years, 4 months ago (2011-08-10 22:42:37 UTC) #10
brettw
http://codereview.chromium.org/7537030/diff/19008/chrome/browser/ui/browser_window.h File chrome/browser/ui/browser_window.h (right): http://codereview.chromium.org/7537030/diff/19008/chrome/browser/ui/browser_window.h#newcode345 chrome/browser/ui/browser_window.h:345: // Invoked when the preferred size of the contents ...
9 years, 4 months ago (2011-08-10 23:39:36 UTC) #11
jianli
http://codereview.chromium.org/7537030/diff/19008/chrome/browser/ui/browser_window.h File chrome/browser/ui/browser_window.h (right): http://codereview.chromium.org/7537030/diff/19008/chrome/browser/ui/browser_window.h#newcode345 chrome/browser/ui/browser_window.h:345: // Invoked when the preferred size of the contents ...
9 years, 4 months ago (2011-08-10 23:57:17 UTC) #12
brettw
> On 2011/08/10 23:39:36, brettw wrote: > > I don't totally get this comment and ...
9 years, 4 months ago (2011-08-11 20:06:22 UTC) #13
brettw
http://codereview.chromium.org/7537030/diff/25001/content/browser/tab_contents/tab_contents_delegate.h File content/browser/tab_contents/tab_contents_delegate.h (right): http://codereview.chromium.org/7537030/diff/25001/content/browser/tab_contents/tab_contents_delegate.h#newcode302 content/browser/tab_contents/tab_contents_delegate.h:302: virtual void UpdatePreferredSize(const gfx::Size& pref_size); Although in your case ...
9 years, 4 months ago (2011-08-11 20:06:48 UTC) #14
jianli
Adding Ben and Peter to see if they can help resolve the issues. On 2011/08/11 ...
9 years, 4 months ago (2011-08-12 00:55:26 UTC) #15
Peter Kasting
On 2011/08/12 00:55:26, jianli wrote: > Adding Ben and Peter to see if they can ...
9 years, 4 months ago (2011-08-12 17:19:42 UTC) #16
jianli
Ben, could you please also take a look at tab contents related changes? Thanks. http://codereview.chromium.org/7537030/diff/32001/chrome/browser/ui/browser.cc ...
9 years, 4 months ago (2011-08-16 20:55:57 UTC) #17
Ben Goodger (Google)
http://codereview.chromium.org/7537030/diff/38001/chrome/browser/tab_contents/tab_contents_view_gtk.cc File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right): http://codereview.chromium.org/7537030/diff/38001/chrome/browser/tab_contents/tab_contents_view_gtk.cc#newcode257 chrome/browser/tab_contents/tab_contents_view_gtk.cc:257: if (tab_contents_->delegate()) The piece of feedback I have is ...
9 years, 4 months ago (2011-08-17 19:15:11 UTC) #18
jianli
http://codereview.chromium.org/7537030/diff/38001/chrome/browser/tab_contents/tab_contents_view_gtk.cc File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right): http://codereview.chromium.org/7537030/diff/38001/chrome/browser/tab_contents/tab_contents_view_gtk.cc#newcode257 chrome/browser/tab_contents/tab_contents_view_gtk.cc:257: if (tab_contents_->delegate()) On 2011/08/17 19:15:11, Ben Goodger (Google) wrote: ...
9 years, 4 months ago (2011-08-18 00:20:19 UTC) #19
Ben Goodger (Google)
I just looked at this... confusing! Didn't realize UpdatePreferredSize was also declared on RenderViewHostDelegate::View... On ...
9 years, 3 months ago (2011-08-31 23:39:34 UTC) #20
jianli
On 2011/08/31 23:39:34, Ben Goodger (Google) wrote: > I just looked at this... confusing! Didn't ...
9 years, 3 months ago (2011-09-01 00:19:50 UTC) #21
Ben Goodger (Google)
9 years, 3 months ago (2011-09-01 00:27:13 UTC) #22
LGTM

Powered by Google App Engine
This is Rietveld 408576698