Make panel adjust bounds per preferred size change notification on Windows.

chrome/browser/ui/panels/panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_H_
 #pragma once
 
 #include "chrome/browser/ui/browser_window.h"
 
 #include "base/memory/scoped_ptr.h"
+#include "content/common/notification_observer.h"
+#include "content/common/notification_registrar.h"
 #include "ui/gfx/rect.h"
 
 class NativePanel;
 class PanelManager;
 
 // A platform independent implementation of BrowserWindow for Panels.  This
 // class would get the first crack at all the BrowserWindow calls for Panels and
 // do one or more of the following:
 // - Do nothing.  The function is not relevant to Panels.
 // - Throw an exceptions.  The function shouldn't be called for Panels.
 // - Do Panel specific platform independent processing and then invoke the
 //   function on the platform specific BrowserWindow member.  For example,
 //   Panel size is restricted to certain limits.
 // - Invoke an appropriate PanelManager function to do stuff that might affect
 //   other Panels.  For example deleting a panel would rearrange other panels.
-class Panel : public BrowserWindow {
+class Panel : public BrowserWindow, public NotificationObserver {
  public:
   enum ExpansionState {
    // The panel is fully expanded with both title-bar and the client-area.
    EXPANDED,
    // The panel is shown with the title-bar only.
    TITLE_ONLY,
    // The panel is shown with 3-pxiel line.
    MINIMIZED
   };
 
   virtual ~Panel();
 
   // Returns the PanelManager associated with this panel.
   PanelManager* manager() const;
 
   void SetExpansionState(ExpansionState new_expansion_state);
 
   bool ShouldBringUpTitleBar(int mouse_x, int mouse_y) const;
 
   bool IsDrawingAttention() const;
 
+  // Returns the size of the non-client area, that is, the window size minus
+  // the size of the client area.
+  gfx::Size GetNonClientAreaSize() const;
+
   // BrowserWindow overrides.
   virtual void Show() OVERRIDE;
   virtual void ShowInactive() OVERRIDE;
   virtual void SetBounds(const gfx::Rect& bounds) OVERRIDE;
   virtual void Close() OVERRIDE;
   virtual void Activate() OVERRIDE;
   virtual void Deactivate() OVERRIDE;
   virtual bool IsActive() const OVERRIDE;
   virtual void FlashFrame() OVERRIDE;
   virtual gfx::NativeWindow GetNativeHandle() OVERRIDE;
@@ skipping 75 matching lines @@
 #endif
   virtual void PrepareForInstant() OVERRIDE;
   virtual void ShowInstant(TabContentsWrapper* preview) OVERRIDE;
   virtual void HideInstant(bool instant_is_active) OVERRIDE;
   virtual gfx::Rect GetInstantBounds() OVERRIDE;
   virtual WindowOpenDisposition GetDispositionForPopupBounds(
       const gfx::Rect& bounds) OVERRIDE;
 #if defined(OS_CHROMEOS)
   virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) OVERRIDE;
 #endif
+  virtual void UpdatePreferredSize(const gfx::Size& pref_size) OVERRIDE;
+
+  // NotificationObserver overrides.
+  virtual void Observe(int type,
+                       const NotificationSource& source,
+                       const NotificationDetails& details) OVERRIDE;
 
   // Construct a native panel BrowserWindow implementation for the specified
   // |browser|.
   static NativePanel* CreateNativePanel(Browser* browser,
                                         Panel* panel,
                                         const gfx::Rect& bounds);
 
   // Gets the extension from the browser that a panel is created from.
   // Returns NULL if it cannot be found.
   static const Extension* GetExtension(Browser* browser);
 
 #ifdef UNIT_TEST
   NativePanel* native_panel() { return native_panel_; }
 #endif
 
   Browser* browser() const;
   ExpansionState expansion_state() const { return expansion_state_; }
 
  protected:
   virtual void DestroyBrowser() OVERRIDE;
 
  private:
   friend class PanelManager;
 
   // Panel can only be created using PanelManager::CreatePanel().
   Panel(Browser* browser, const gfx::Rect& bounds);
 
+  // Called from PanelManager to update the bounds that should be used when the
+  // panel is expanded.
+  void SetRestoredBounds(const gfx::Rect& bounds);
+
   // This is different from BrowserWindow::SetBounds():
   // * SetPanelBounds() is only called by PanelManager to manage its position.
   // * SetBounds() is called by the API to try to change the bounds, which is
   //   not allowed for Panel.
   void SetPanelBounds(const gfx::Rect& bounds);
 
+  // Updates the maximum size.
+  void SetMaximumSize(const gfx::Size& max_size);
+
+  // The initial size. The panel cannot shrink to be smaller than that.

[Dmitry Titov, 2011/08/05 19:02:20]

As discussed, lets rename all these into "minimum_size". Because it is that. We
also should probably mention somewhere in the docs that the size people pass to
API is minimum size of the panel.

[jianli, 2011/08/09 19:56:16]

Done.

+  // Used by PanelManager in updating the panel bounds as responding to the
+  // dynamic content update.
+  gfx::Size initial_size_;
+
+  // The maximum size that the panel can grow to. Note that the maximum width is
+  // affected by the available horizontal space when panels are added, removed,

[Dmitry Titov, 2011/08/05 19:02:20]

Lets add comment about how this size is used - to specify the size beyond which
the panel is not going to grow to accomodate growing content so WebKit should
throw in, layout and render scrollbars there.

[jianli, 2011/08/09 19:56:16]

Done.

+  // or size changed.
+  gfx::Size max_size_;
+
   // Platform specifc implementation for panels.  It'd be one of
   // PanelBrowserWindowGtk/PanelBrowserView/PanelBrowserWindowCocoa.
   NativePanel* native_panel_;  // Weak, owns us.
 
   ExpansionState expansion_state_;
 
+  NotificationRegistrar registrar_;
+
   DISALLOW_COPY_AND_ASSIGN(Panel);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_H_